GatedSizedPastelRecipe#getIngredients: Don't attempt to access null SizedIngredients - #249
Open
unilock wants to merge 3 commits into
Open
GatedSizedPastelRecipe#getIngredients: Don't attempt to access null SizedIngredients#249unilock wants to merge 3 commits into
unilock wants to merge 3 commits into
Conversation
…izedIngredients Also use Stream#toList where applicable, which can be more optimized
Having it set to 0 causes the ComponentMap of items using it to fail to encode, as DataComponentTypes.MAX_DAMAGE requires a positive integer. I'm not aware of any way to trigger the issue this commit fixes in vanilla / with Pastel alone, but it can be reproduced by attempting to insert a bedrock tool into an Excorrelation storage system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash when
GatedSizedPastelRecipe#getIngredientsis called for certain recipes (unsure which ones, but iterating the recipe registry will trigger it)Also makes it build again
EDIT: Also increases the "durability" of bedrock tools from
0to fix their components failing to encode (see commit details for more information). The chosen durability value is bogus