Skip to content

fix: Resolve issue with building function package separately fails with Terraform v1.13 & later #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anioool wants to merge 2 commits into from
Closed

fix: Resolve issue with building function package separately fails with Terraform v1.13 & later #728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f94e71
Update main.tf
anioool Jan 26, 2026
7c7169f
fix: typo
anioool Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ resource "aws_lambda_function" "this" {
}

filename = local.filename
source_code_hash = var.ignore_source_code_hash ? null : (local.filename == null ? false : fileexists(local.filename)) ? filebase64sha256(local.filename) : null
source_code_hash = var.ignore_source_code_hash ? null : (local.filename == null ? false : try(filebase64sha256(local.filename), null))
Copy link
Contributor

@lorengordon lorengordon Jan 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will return false when local.filename == null, which changes the meaning of the original logic. It should return null in that condition. I suggest rewriting:

Suggested change
source_code_hash = var.ignore_source_code_hash ? null : (local.filename == null ? false : try(filebase64sha256(local.filename), null))
source_code_hash = var.ignore_source_code_hash || local.filename == null ? null : try(filebase64sha256(local.filename), null)

Copy link
Author

@anioool anioool Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case when local.filename == null then the logic remain unchanged and false is going to be returned. The change touches the false path where local.filename != null and change the logic in a way that we no longer do the pre check if the file exists but we tries to generate hash with eventual fallback to null value. It's the same logic but with no fileexists function involved

Copy link
Contributor

@lorengordon lorengordon Jan 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It never returned false before. It returned null. The logic was quite convoluted. Where you are seeing the false, was actually the "test" for the third ternary operator. When the test returned false, the ternary was written to return null.


s3_bucket = local.s3_bucket
s3_key = local.s3_key
Expand Down Expand Up @@ -187,7 +187,7 @@ resource "aws_lambda_layer_version" "this" {
skip_destroy = var.layer_skip_destroy

filename = local.filename
source_code_hash = var.ignore_source_code_hash ? null : (local.filename == null ? false : fileexists(local.filename)) ? filebase64sha256(local.filename) : null
source_code_hash = var.ignore_source_code_hash ? null : (local.filename == null ? false : try(filebase64sha256(local.filename), null))

s3_bucket = local.s3_bucket
s3_key = local.s3_key
Expand Down
Loading