You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update terraform import example commands in UPGRADE-2.0.md.
Current terraform import commands in the State Changes example snippet suggest importing SG rules, created via pre 2.0 module versions, using the pattern of an SG rule ID that belongs to aws_security_group_rule resource (i.e. sg-xxx).
Meanwhile, the aws_vpc_security_group_ingress_rule resource ID for import is slightly different (i.e. sgr-xxx).
Motivation and Context
Accurate documentation is nice
Breaking Changes
N/A
How Has This Been Tested?
I have executed pre-commit run -a on my pull request
john-terraform
changed the title
docs: updated import commands for state changes section
Updated import commands for state changes section
Dec 3, 2025
john-terraform
changed the title
Updated import commands for state changes section
docs: Updated import commands for state changes section in UPGRADE-2.0.md
Dec 3, 2025
bryantbiggs
changed the title
docs: Updated import commands for state changes section in UPGRADE-2.0.md
docs: Update import commands for state changes section
Dec 3, 2025
actually, this is wrong - security group IDs start with sg-*. Either way, its just a reference for what users need to provide since we cannot tell them what their security group ID is
@bryantbiggs, you are right about the security group IDs. In this particular case, the reference is made for importing existing security group rules, not the security group resources, due to migration from a single aws_security_group_rule resource to instances of aws_vpc_security_group_ingress_rule within the module in 2.0.0.
In this PR, I adjusted the import reference for aws_vpc_security_group_ingress_rule accordingly, which should include the security group rule ID [Resource: aws_vpc_security_group_ingress_rule].
Came across this document today, while upgrading to the EFS module 2.0.0, noticed this minor mistake (probably someone's typo), and decided to correct it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
terraform importexample commands in UPGRADE-2.0.md.Current
terraform importcommands in the State Changes example snippet suggest importing SG rules, created via pre 2.0 module versions, using the pattern of an SG rule ID that belongs to aws_security_group_rule resource (i.e.sg-xxx).Meanwhile, the aws_vpc_security_group_ingress_rule resource ID for import is slightly different (i.e.
sgr-xxx).Motivation and Context
Breaking Changes
How Has This Been Tested?
pre-commit run -aon my pull request