Skip to content

Switched from jue_01 to glb_01#815

Draft
Abigael-JT wants to merge 1 commit into
teragrep:mainfrom
Abigael-JT:switch-from-jue_01-to-glb_01
Draft

Switched from jue_01 to glb_01#815
Abigael-JT wants to merge 1 commit into
teragrep:mainfrom
Abigael-JT:switch-from-jue_01-to-glb_01

Conversation

@Abigael-JT
Copy link
Copy Markdown
Contributor

Description

Checklists

Testing

General

  • I have checked that my test files and functions have meaningful names.
  • I have checked that each test tests only a single behavior.
  • I have done happy tests.
  • I have tested only my own code.
  • I have tested at least all public methods.

Assertions

  • I have checked that my tests use assertions and not runtime overhead.
  • I have checked that my tests end in assertions.
  • I have checked that there is no comparison statements in assertions.
  • I have checked that assertions are in tests and not in helper functions.
  • I have checked that assertions for iterables are outside of for loops and both sides of the iteration blocks.
  • I have checked that assertions are not tested inside consumers.

Testing Data

  • I have tested algorithms and anything else with the possibility of unbound growth.
  • I have checked that all testing data is local and fully replaceable or reproducible or both.
  • I have checked that all test files are standalone.
  • I have checked that all test-specific fake objects and classes are in the test directory.
  • I have checked that my tests do not contain anything related to customers, infrastructure or users.
  • I have checked that my tests do not contain non-generic information.
  • I have checked that my tests do not do external requests and are not privately or publicly routable.

Statements

  • I have checked that my tests do not use throws for exceptions.
  • I have checked that my tests do not use try-catch statements.
  • I have checked that my tests do not use if-else statements.

Java

  • I have checked that my tests for Java uses JUnit library.
  • I have checked that my tests for Java uses JUnit utilities for parameters.

Other

  • I have only tested public behavior and not private implementation details.
  • I have checked that my tests are not (partially) commented out.
  • I have checked that hand-crafted variables in assertions are used accordingly.
  • I have tested Object Equality.
  • I have checked that I do not have any manual tests or I have a valid reason for them and I have explained it in the PR description.

Code Quality

  • I have checked that my code follows metrics set in Procedure: Class Metrics.
  • I have checked that my code follows metrics set in Procedure: Method Metrics.
  • I have checked that my code follows metrics set in Procedure: Object Quality.
  • I have checked that my code does not have any NULL values.
  • I have checked my code does not contain FIXME or TODO comments.

@Abigael-JT Abigael-JT self-assigned this Feb 10, 2026
@Abigael-JT Abigael-JT linked an issue Feb 10, 2026 that may be closed by this pull request
@Abigael-JT
Copy link
Copy Markdown
Contributor Author

In progress: debugging failed test parseEvalSearchmatchImplicitRawCatalystTest() in evalTest.java
Caused by changes made in EvalStatement.java

@Abigael-JT
Copy link
Copy Markdown
Contributor Author

created a ticket for the issue that caused the failed test parseEvalSearchmatchImplicitRawCatalystTest()
teragrep/glb_01#7

@kortemik kortemik requested a review from eemhu March 17, 2026 08:01
@kortemik
Copy link
Copy Markdown
Member

kortemik commented Mar 24, 2026

I think we should not use glob at all in the IndexStatement. it should not even be rlike but just like with * replaced with % in my opinion. @eemhu point here

@eemhu
Copy link
Copy Markdown
Contributor

eemhu commented Apr 15, 2026

I think we should not use glob at all in the IndexStatement. it should not even be rlike but just like with * replaced with % in my opinion. @eemhu point here

Yes, it's not really glob. Only wildcard functionality is and should be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

switch from jue_01 GlobToRegEx to glb_01

3 participants