Sidebar: dismiss "Action needed" connection prompts#165
Merged
Conversation
A member who doesn't intend to wire up a given connection had no way to quiet its sidebar nag. Add a small "Dismiss" text link next to each Connect/Set button; dismissing hides that prompt, persisted per-user in localStorage (keyed by the connection's source:toolkit:name, matching the sidebar-nav/docs-nav persistence pattern). A genuinely new missing connection still surfaces. Extracts the missing-connection cards from the server-rendered app-shell into a client MissingConnectionCards component; the LLM-key and failing-agent alerts stay as-is. tsc + eslint clean, 101 tests pass, full build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (!ready) return null; | ||
| const visible = items.filter((it) => !dismissed.has(it.key)); |
Contributor
There was a problem hiding this comment.
When visible becomes empty after dismissing the last missing-connection card, the parent app-shell still renders the Action needed wrapper because it only checks missingConnections.length. That leaves a blank section/header in the sidebar when these were the only alerts. Consider moving the section/header visibility into this client component, or otherwise hiding the parent wrapper once there are no visible cards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask: let me dismiss an "Action needed" connection prompt in the sidebar if I don't want to do that connection — a smaller text link next to "Connect".
Adds a small "Dismiss" text link next to each Connect/Set button in the sidebar's "Action needed" list. Dismissing hides that prompt, persisted per-user in localStorage (keyed by the connection's
source:toolkit:name, matching the existing sidebar-nav / docs-nav persistence). A genuinely new missing connection still surfaces (different key).Extracts the missing-connection cards from the server-rendered
app-shellinto a small clientMissingConnectionCardscomponent; the LLM-key and failing-agent alerts are unchanged.tsc+eslintclean, 101 tests pass, fullnext buildgreen.🤖 Generated with Claude Code