fix: strip go.mod comments from Makefile tool versions - #144
Open
MaxRink wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the build tooling by fixing how the Makefile extracts ENVTEST_VERSION from go.mod, ensuring trailing // indirect comments don’t get included and break go install for setup-envtest.
Changes:
- Update the
sedcapture forENVTEST_VERSIONto stop at the first space, stripping any trailing comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MaxRink
force-pushed
the
fix/envtest-version
branch
from
May 20, 2026 09:10
69b1dff to
9ecf247
Compare
MaxRink
force-pushed
the
fix/envtest-version
branch
from
June 7, 2026 15:38
9ecf247 to
29d1a1d
Compare
MaxRink
changed the title
MaxRink
force-pushed
the
fix/envtest-version
branch
from
August 21, 2026 09:19
29d1a1d to
7398f8a
Compare
Extract only the version token for controller-gen and setup-envtest so trailing go.mod comments are not passed to go install.
MaxRink
force-pushed
the
fix/envtest-version
branch
from
August 21, 2026 09:25
7398f8a to
2bfa9d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefile tool-version parsing now captures only version tokens from
go.mod, preventing trailing comments such as// indirectfrom being included ingo installarguments.Changes
CONTROLLER_GEN_VERSIONextraction to the token before the first space.ENVTEST_VERSION.Validation
go.modat this PR head; they return version tokens without trailing comments.