Attach test environment to its invocation#4452
Merged
Conversation
happz
added
code | no functional change
16 tasks
happz
force-pushed
the
test-invocation-environment-moved
branch
from
9b129e8 to
6d96626
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
happz
force-pushed
the
stopwatch-use-formatted-attributes
branch
from
252dce7 to
bbf844d
Compare
happz
force-pushed
the
test-invocation-environment-moved
branch
from
35e6411 to
1263261
Compare
happz
force-pushed
the
test-invocation-environment-moved
branch
from
1263261 to
f0f4627
Compare
Contributor
Author
|
/packit restart-failed |
happz
force-pushed
the
test-invocation-environment-moved
branch
from
f0f4627 to
c397570
Compare
thrix
approved these changes
Jan 13, 2026
Contributor
thrix
left a comment
thrix
left a comment
There was a problem hiding this comment.
Conclusion
The refactoring achieves its goal of centralizing environment management in TestInvocation. The implementation is sound after the fixes for the caching issue. The "no functional change" label appears accurate - this is purely an internal refactoring that presents the same environment through a different mechanism.
The code is well-structured and all identified issues have been addressed.
psss
approved these changes
Jan 13, 2026
This will present the same environment to all users of test invocation, from checks to test itself and its results. It was also not clear who is responsible for the environment and its composition, now when it's part of the invocation, all `execute` plugins should see the same content.
thrix
force-pushed
the
test-invocation-environment-moved
branch
from
c397570 to
46aa5e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will present the same environment to all users of test invocation, from checks to test itself and its results. It was also not clear who is responsible for the environment and its composition, now when it's part of the invocation, all
executeplugins should see the same content.Pull Request Checklist