Add example tests for artifact providers #4449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavdaren
added
the
ci | skip
vaibhavdaren
force-pushed
the
vaibhav-artifact-install-integration-tests
branch
3 times, most recently
from
dc828a0 to
ca4c960
Compare
vaibhavdaren
added
ci | full test
vaibhavdaren
force-pushed
the
vaibhav-artifact-install-integration-tests
branch
from
ca4c960 to
a5284c8
Compare
LecrisUT
reviewed
Jan 7, 2026
Contributor
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
Is the goal for this PR to split the /tests/prepare/artifact into individual provider tests? If so, why not add it to it instead? For example you can add a for loop in the test.sh to loop over each provider if that is the intent.
One concern with the current approach is that the koji list-tagged logic is quite non-trivial and would prefer to be defined in a single place.
vaibhavdaren
force-pushed
the
vaibhav-artifact-install-integration-tests
branch
2 times, most recently
from
d3d3e13 to
92bad06
Compare
vaibhavdaren
added
the
code | no functional change
vaibhavdaren
force-pushed
the
vaibhav-artifact-install-integration-tests
branch
from
92bad06 to
6e7c129
Compare
tcornell-bus
reviewed
Jan 9, 2026
Collaborator
tcornell-bus
left a comment
tcornell-bus
left a comment
There was a problem hiding this comment.
Minor questions, but LGTM overall!
tcornell-bus
reviewed
Jan 9, 2026
tcornell-bus
approved these changes
Jan 12, 2026
Collaborator
tcornell-bus
left a comment
tcornell-bus
left a comment
There was a problem hiding this comment.
LGTM, but in the tests on fedora-rawhide there is an issue with finding make on koji I guess?
vaibhavdaren
force-pushed
the
vaibhav-artifact-install-integration-tests
branch
from
b0c23dc to
d3a60c8
Compare
Contributor
Author
Yes, this is 1st PR for the issue (This provides more of a framework and common functions). I will send separate PR's for each of the other providers to keep it simple for the reviewers. Used Related to to link the PR instead. |
LecrisUT
reviewed
Jan 19, 2026
vaibhavdaren
force-pushed
the
vaibhav-artifact-install-integration-tests
branch
2 times, most recently
from
cb2c5b3 to
b8f1dbe
Compare
happz
force-pushed
the
vaibhav-artifact-install-integration-tests
branch
from
b8f1dbe to
f6ca434
Compare
Add simple, example-based integration tests for artifact providers: - koji.build: Fetches packages from Koji using build IDs - repository-url: Configures external package repositories - multi: Demonstrates using multiple providers together These tests serve as usage examples and verify basic functionality. Each test: - Shows clear usage of the --provide argument - Runs a complete tmt workflow - Verifies packages are installed correctly Once the design is approved, additional providers (koji.task, koji.nvr, file, copr.build, brew.*) can be added following the same pattern. Related to #4420
- Remove plan file test phases, keep only CLI override tests - Use koji.build:DUMMY placeholder with explanatory comments - Enhance lib/common.sh with perl regex documentation and rlLog wrappers - Refactor parent test.sh to use shared get_koji_build_id function - Fix FMF inheritance: add test selector to parent, remove duplicate tags - Improve assertions to check specific log messages - Add package source verification using dnf info --installed
Prevents stale values from persisting if the function is called multiple times and fails on a subsequent call.
- Change grep -eq to -Eq (capital E enables extended regex for \s*) - Update regex to handle dnf5 output format which has space before colon (e.g., "From repository :" instead of "From repository:")
happz
force-pushed
the
vaibhav-artifact-install-integration-tests
branch
from
f6ca434 to
3a9909b
Compare
This was referenced Jan 20, 2026
vaibhavdaren
added a commit
that referenced
this pull request
Jan 21, 2026
Add example-based integration test for the copr-repository artifact provider using mariobl/pyspread Copr repository. The test verifies that the pyspread package can be installed from the Copr repository and checks the package source. Related to #4449
1 task
vaibhavdaren
added a commit
that referenced
this pull request
Jan 23, 2026
Add example-based integration test for the copr-repository artifact provider using mariobl/pyspread Copr repository. The test verifies that the pyspread package can be installed from the Copr repository and checks the package source. Related to #4449
vaibhavdaren
added a commit
that referenced
this pull request
Jan 23, 2026
Add example-based integration test for the copr-repository artifact provider using mariobl/pyspread Copr repository. The test verifies that the pyspread package can be installed from the Copr repository and checks the package source. Related to #4449
happz
pushed a commit
that referenced
this pull request
Jan 23, 2026
Add example-based integration test for the copr-repository artifact provider using mariobl/pyspread Copr repository. The test verifies that the pyspread package can be installed from the Copr repository and checks the package source. Related to #4449
happz
pushed a commit
that referenced
this pull request
Jan 23, 2026
Add example-based integration test for the copr-repository artifact provider using mariobl/pyspread Copr repository. The test verifies that the pyspread package can be installed from the Copr repository and checks the package source. Related to #4449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add simple, example-based integration tests for artifact providers:
Once the design is approved, additional providers (koji.task, koji.nvr, file, copr.build, brew.*) can be added following the same pattern.
Related to #4420