feat: upgrade Node.js version to 25 and update related documentation#376
Merged
feat: upgrade Node.js version to 25 and update related documentation#376
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the repository’s local development Node.js version to 25, updates the devcontainer to use a Debian base image with a Node feature install, and refreshes contributor/docs guidance to match the new version.
Changes:
- Bump local dev Node.js version from 24 → 25 via
.node-versionand update related documentation. - Switch devcontainer image to
mcr.microsoft.com/devcontainers/base:trixieand install Node 25 viaghcr.io/devcontainers/features/node:1. - Adjust devcontainer post-create setup (git safe.directory + node_modules ownership).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/development.md | Updates devcontainer + manual setup docs to Node.js 25 and new base image. |
| CONTRIBUTING.md | Updates prerequisite Node.js version to 25+. |
| AGENTS.md | Updates environment guidance to Node.js 25+. |
| .node-version | Sets Node version to 25 for local dev and CI setup-node. |
| .github/copilot-instructions.md | Updates tech stack docs to reflect Node.js 25+. |
| .devcontainer/postCreateCommand.bash | Updates safe.directory path and node_modules ownership command for new base image/user. |
| .devcontainer/devcontainer.json | Switches base image and adds Node 25 devcontainer feature. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
virgofx
force-pushed
the
feat/update-internal-node25-and-related-docs
branch
from
181bc36 to
895f739
Compare
📋 Release Plan
📝 Changelog
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the local development environment from Node.js 24 to Node.js 25 and switches the devcontainer base image to support it. Also fixes two pre-existing bugs in the post-create script.
What Changed
.node-version:24→25.devcontainer/devcontainer.json:typescript-node:24tobase:trixie(Microsoft only publishes devcontainer Node images for even/LTS versions; Node 25 is odd/current)ghcr.io/devcontainers/features/node:1feature with"version": "25"to install Node.js via nvm.devcontainer/postCreateCommand.bash:chown node:node→chown "$(id -u):$(id -g)"(base:trixieusesvscodeuser, notnode)terraform-modules-releaser→terraform-module-releaserAGENTS.md,CONTRIBUTING.md,docs/development.md,.github/copilot-instructions.mdValidation
npm run typecheck— passesnpm run check:fix— passes, no fixes appliednpm run textlint:fix— passespostCreateCommandcompletes successfullyRisks / Notes
node-version-file: .node-version, so they will automatically pick up Node 25base:trixieimage no longer bundles TypeScript/ESLint globally, but both are already project devDependencies so this has no practical effect