This repository was archived by the owner on Apr 14, 2026. It is now read-only.
Refactor remote Config fetching request to be asynchronous - #1211
Draft
SleepySquash wants to merge 6 commits into
Draft
Refactor remote Config fetching request to be asynchronous#1211SleepySquash wants to merge 6 commits into
Config fetching request to be asynchronous#1211SleepySquash wants to merge 6 commits into
Conversation
Contributor
Author
FCM |
SleepySquash
marked this pull request as ready for review
April 23, 2025 09:36
SleepySquash
marked this pull request as draft
April 28, 2025 07:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
Offline mode DOESN'T work currently. This is caused by
Config.init()method fetching the remote config in aawaitfashion. This causes application to await the remote request to be done and fetched. However, when there's no Internet connection or the request hangs up, then the application doesn't launch at all.Solution
This PR fixes this issue by making the request non-
awaitable.Checklist
k::labels applied