Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

Refactor remote Config fetching request to be asynchronous - #1211

Draft
SleepySquash wants to merge 6 commits into
mainfrom
fix-remote-config-hanging-up
Draft

Refactor remote Config fetching request to be asynchronous#1211
SleepySquash wants to merge 6 commits into
mainfrom
fix-remote-config-hanging-up

Conversation

@SleepySquash

@SleepySquash SleepySquash commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

Synopsis

Offline mode DOESN'T work currently. This is caused by Config.init() method fetching the remote config in a await fashion. This causes application to await the remote request to be done and fetched. However, when there's no Internet connection or the request hangs up, then the application doesn't launch at all.

Solution

This PR fixes this issue by making the request non-awaitable.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels Apr 21, 2025
@SleepySquash SleepySquash added this to the 0.5.0 milestone Apr 21, 2025
@SleepySquash SleepySquash self-assigned this Apr 21, 2025
@SleepySquash

SleepySquash commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

FCM

Refactor remote `Config` fetching request to be asynchronous (#1211)

@SleepySquash SleepySquash modified the milestones: 0.4.2, 0.5.0 Apr 22, 2025
@SleepySquash
SleepySquash marked this pull request as ready for review April 23, 2025 09:36
@SleepySquash
SleepySquash marked this pull request as draft April 28, 2025 07:21
@SleepySquash SleepySquash modified the milestones: 0.4.3, 0.5.0, 0.6.0 May 6, 2025
@SleepySquash SleepySquash modified the milestones: 0.5.1, 1.0.0, 0.6.0 Jun 3, 2025
@SleepySquash SleepySquash modified the milestones: 0.5.2, 0.6.0 Jul 1, 2025
@SleepySquash SleepySquash modified the milestones: 0.5.3, 0.6.0 Jul 10, 2025
@SleepySquash SleepySquash modified the milestones: 0.5.4, 0.6.0 Jul 24, 2025
@SleepySquash SleepySquash removed this from the 0.6.0 milestone Aug 7, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.8, 0.7.0 Nov 3, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.9, 0.7.0, 0.6.10 Nov 11, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.11, 0.7.0 Nov 24, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.12, 0.7.0 Dec 1, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.13, 0.7.0 Dec 8, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.14, 0.7.0, 0.8.0 Dec 19, 2025
@SleepySquash SleepySquash modified the milestones: 0.7.1, 0.8.0, 0.7.2 Jan 7, 2026
@SleepySquash SleepySquash modified the milestones: 0.8.0, 0.9.0, 0.8.1 Jan 21, 2026
@SleepySquash SleepySquash modified the milestones: 0.8.2, 0.9.0, 0.10.0 Feb 2, 2026
@SleepySquash SleepySquash modified the milestones: 0.9.1, 0.10.0 Feb 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code

Projects

Status: First priority

Development

Successfully merging this pull request may close these issues.

1 participant