Error when doing export { ... } from of a deferred export#10
Open
nicolo-ribaudo wants to merge 1 commit intomainfrom
Open
Error when doing export { ... } from of a deferred export#10nicolo-ribaudo wants to merge 1 commit intomainfrom
export { ... } from of a deferred export#10nicolo-ribaudo wants to merge 1 commit intomainfrom
Conversation
nicolo-ribaudo
commented
Oct 24, 2025
| 1. Let _resolution_ be _module_.ResolveExport(_e_.[[ExportName]]). | ||
| 1. If _resolution_ is either *null* or ~ambiguous~, throw a *SyntaxError* exception. | ||
| 1. Assert: _resolution_ is a ResolvedBinding Record. | ||
| 1. <ins>If _resolution_.[[Module]] is a Cyclic Module Record and _e_ was exported by an |ExportDeclaration| with an |ExportFromClause|, then</ins> |
Member
Author
There was a problem hiding this comment.
This is a tiny bit hand-wavy, I plan to add an internal slot on Source Text Module Record that lists the bindings that "were exported by an |ExportDeclaration| with an |ExportFromClause|".
This was referenced Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5 (comment)
This PR makes it an error to make
export { foo } from "x"of a binding that was exported asexport defer { foo } from "somewhere else", since it nullifies the benefits ofdefer. Developers would still be able to force this behavior by doingimport { foo } from "x"; export { foo }, but it prevents them from doing accidentally.I plan to discuss this PR at the next plenary.