feat(updater): make pubkey optional in cli + bundler#15173
Open
wovw wants to merge 1 commit intotauri-apps:devfrom
Open
feat(updater): make pubkey optional in cli + bundler#15173wovw wants to merge 1 commit intotauri-apps:devfrom
wovw wants to merge 1 commit intotauri-apps:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion PR to tauri-apps/plugins-workspace#3114, addressing tauri-apps/plugins-workspace#2438.
Currently, the Tauri CLI strictly requires the updater
pubkeyto be hardcoded intauri.conf.jsonso it can verify that the private key matches the public key during the build/bundling process. This prevents developers from securely fetching or providing the public key dynamically at runtime. This PR relaxes that build-time constraint.Changes
pubkeyto anOption<String>inUpdaterConfigandUpdaterSettings.tauri-cli/src/bundle.rsto handle an optionalpubkey.pubkeyis missing from the config, the CLI now skips the public/private key verification step and instead emits a compile-time warning reminding the developer to ensure it is set at runtime.pubkeyto be present before performing an update is now handled at runtime in fix(updater): make pubkey optional in tauri config, check if set at runtime (fixes #2438) plugins-workspace#3114cargo testpasses