fix(bundler): use relative symlinks for AppImage .DirIcon and .desktop#15141
Open
alexrzem wants to merge 1 commit intotauri-apps:devfrom
Open
fix(bundler): use relative symlinks for AppImage .DirIcon and .desktop#15141alexrzem wants to merge 1 commit intotauri-apps:devfrom
alexrzem wants to merge 1 commit intotauri-apps:devfrom
Conversation
The symlink targets were created using app_dir_path.join() which produced absolute paths pointing to the build directory. When the AppImage is mounted at runtime, these symlinks are broken, preventing appimaged and file managers from extracting the application icon.
Contributor
Package Changes Through b61658bThere are 7 changes which include tauri-macos-sign with patch, tauri-build with patch, tauri with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symlink targets were created using app_dir_path.join() which produced absolute paths pointing to the build directory. When the AppImage is mounted at runtime, these symlinks are broken, preventing appimaged and file managers from extracting the application icon.
Fixes #15110
Confirms #15122 without using AI.
cargo testpassed all testscargo clippyfinished with no errors