tarantool: align source precedence with documentation#61
Merged
Conversation
The buildInner ordering added centralized storage after the local YAML file collector, giving storage higher priority than the file. This contradicts the documented precedence (file > storage) and silently overrode local-file values with values from centralized storage. - Build the source list top-down in documented precedence order (TT_* > file/dir > storage > TT_*_DEFAULT) and add to the inner builder in reverse, since AddCollector treats later additions as higher priority. - Rename TestBuild_StorageOverridesFile to TestBuild_FileOverridesStorage and update assertions to match the documented behavior.
bigbes
force-pushed
the
bigbes/gh-no-fix-tarantool-order
branch
from
5012b6e to
f620bc2
Compare
Coverage Report for CI Build 25459643976Coverage increased (+0.04%) to 85.423%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
sssciel
approved these changes
May 6, 2026
patapenka-alexey
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tarantool builder docs state precedence (highest → lowest) as TT_* env vars, local YAML file, centralized storage, TT_*_DEFAULT env vars, but
buildInnerwas adding the storage collector after the file collector — and sinceAddCollectoris last-wins, that gave centralized storage higher priority than the local file, silently overriding file values from storage.Reorganize
buildInnerso sources are listed top-down in the documented precedence order (env > file/dir > storage > env-default) and appended to the inner builder in reverse. Behavior now matches the docs: the local YAML file overrides centralized storage, with storage filling in keys absent from the file.The previous
TestBuild_StorageOverridesFilewas asserting the doc-mismatching behavior; renamed toTestBuild_FileOverridesStorageand flipped its assertions.