Binstall release metadata#861
Open
LittleBoxOfSunshine wants to merge 2 commits intotamasfe:masterfrom
Open
Conversation
e5b89f4 to
5e59018
Compare
5e59018 to
32a7bd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binstall support can be added via metadata that explains what the naming pattern(s) are for the github releases.
This change adds that, which partially addresses #827 by enabling binstall support on windows:
On Linux, the naming pattern is correct but binstall doesn't support the
gzformat, so this will continue to fall back to installing from source like it already does today. Since this support may come in the future, I went with adding this unconditionally so that support would be automatic / retroactive.If that isn't desired, it could be gated like so: