[Misc] Explicitly cast indices to int32 in snode_deactivate to preven…#8599
Open
bluevisor wants to merge 1 commit intotaichi-dev:masterfrom
Open
[Misc] Explicitly cast indices to int32 in snode_deactivate to preven…#8599bluevisor wants to merge 1 commit intotaichi-dev:masterfrom
bluevisor wants to merge 1 commit intotaichi-dev:masterfrom
Conversation
Contributor
|
/rebase |
Contributor
|
/rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a Taichi warning in
_kernels.pythat occurs during implicit casting in thesnode_deactivatefunction. The warning was as follows:Changes Made
snode_deactivateto explicitly cast each element inItoint32before callingdeactivate, which suppresses the implicit casting warning.Rationale
Explicitly casting to
int32prevents the warning and ensures that the code adheres to expected data types.Testing
snode_deactivate.snode_deactivatestill functions as expected post-update.