Additional tests for attribute value normalization#946
Conversation
Add tests for: * recursion limit boundary testsing * edge cases around malformed or invalid entity and character references * resolution of predefined entities Some existing tests were also re-sorted slightly.
dralley
force-pushed
the
more-avn-tests
branch
from
8a3f613 to
49b6415
Compare
| Ok("already normalized".into()) | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Already existed, just moved
|
Apologies for the bad diff formatting. I can try to split the moves from the additions if you prefer. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #946 +/- ##
==========================================
+ Coverage 55.00% 56.39% +1.38%
==========================================
Files 44 44
Lines 16816 17579 +763
==========================================
+ Hits 9249 9913 +664
- Misses 7567 7666 +99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| #[test] | ||
| fn predefined_entities() { |
There was a problem hiding this comment.
This would arguably make more sense as a test of Attribute::normalized_value()
Mingun
left a comment
Mingun
left a comment
There was a problem hiding this comment.
Good additions. Yes, moving in separate commit would be preferred, but changes here not so big and I recognized the move.
LGTM
3 participants
Add tests for:
Some existing tests were also re-sorted slightly.