Skip to content

Implement From<LocalName> on QName - #1015

Merged
dralley merged 2 commits into
tafia:masterfrom
Tpt:tpt/from-local-name
Sep 2, 2026
Merged

Implement From<LocalName> on QName#1015
dralley merged 2 commits into
tafia:masterfrom
Tpt:tpt/from-local-name

Conversation

@Tpt

@Tpt Tpt commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Tpt
Tpt force-pushed the tpt/from-local-name branch from 409f24a to 9b6d771 Compare September 1, 2026 19:40
@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.15%. Comparing base (e00ae5c) to head (e4c5519).
⚠️ Report is 74 commits behind head on master.

Files with missing lines Patch % Lines
src/name.rs 0.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
- Coverage   57.31%   55.15%   -2.16%     
==========================================
  Files          46       51       +5     
  Lines       18197    18794     +597     
==========================================
- Hits        10429    10366      -63     
- Misses       7768     8428     +660     
Flag Coverage Δ
unittests 55.15% <0.00%> (-2.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dralley

dralley commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

This looks fine. Did you want to implement this suggestion, or do you think it's fine without it?

It seems that it will be even safe to add impl PartialEq<Rhs = QName> for LocalName and impl PartialEq<Rhs = LocalName> for QName, so you may directly check equivalence of local names and qualified names.

Comment thread Changelog.md Outdated
### New Features

- [#1010]: Implement `fmt::Display` on `QName`, `LocalName`, `Prefix` and `Namespace`.
- [#1011]: Implement `From<LocalName>` on `QName`.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant #1015?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Fixed.

@Tpt

Tpt commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@dralley I would tend to think it's fine without it but glad to add it in an other MR if you want

@dralley
dralley merged commit 2eaa844 into tafia:master Sep 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants