Implement From<LocalName> on QName - #1015
Conversation
5c1ec34 to
409f24a
Compare
409f24a to
9b6d771
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1015 +/- ##
==========================================
- Coverage 57.31% 55.15% -2.16%
==========================================
Files 46 51 +5
Lines 18197 18794 +597
==========================================
- Hits 10429 10366 -63
- Misses 7768 8428 +660
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This looks fine. Did you want to implement this suggestion, or do you think it's fine without it?
|
| ### New Features | ||
|
|
||
| - [#1010]: Implement `fmt::Display` on `QName`, `LocalName`, `Prefix` and `Namespace`. | ||
| - [#1011]: Implement `From<LocalName>` on `QName`. |
|
@dralley I would tend to think it's fine without it but glad to add it in an other MR if you want |
No description provided.