Move hardcoded strings to localized files#368
Merged
Conversation
jacalata
force-pushed
the
jac/collect-strings
branch
from
08de77b to
bbcb1e6
Compare
stephendeoca
approved these changes
Jul 1, 2026
Add or edit some changed messages
- cleaned up string ids that either added "tabcmd" as a prefix or took it off as a prefix incorrectly - add back some deleted strings - incorporate check_strings into the localization build and pushed some output into a log file - added docs in Contributing.md and i18n/README
This edits the *.properties files in place, leaving them ready to check in. When translations are being brought in, we can just paste in the whole file and let it delete the ones we don't need. Drop the filtering step in our .mo generation
alphabetize *just* this block of tabcmd.x
Remaining non-localized strings are used at times when the loc module may not be loaded (e.g throwing an error stack).
Line 245 was calling print() directly, bypassing the file output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
print_and_write now accepts an optional full_list parameter. When the list exceeds 10 items the console gets the truncated summary and the file additionally gets the complete sorted list. Removes four copies of the same truncation pattern from check_build_mode. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The variable was overwritten for every locale with no missing keys, so the "repeated for visibility" block at the end could print a non-English locale's OK message. Rebuild the English summary directly from english_missing_keys at the end instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fixes mypy no-redef errors for set_resource_url_arg and set_destination_filename_arg. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jacalata
force-pushed
the
jac/collect-strings
branch
from
68ddb03 to
155db57
Compare
- Add tabcmd.options.users_file, tabcmd.options.workbook, tabcmd.publish.options.append.detailed, tabcmdparser.help.link, tabcmdparser.help.specific to tabcmd_messages_en.properties - Update datasources_workbooks_views_url_parser.py and delete_group_command.py to use existing tabcmd.* prefixed keys instead of old unprefixed keys that no longer exist Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #307
This changelist removes any remaining hardcoded strings and replaces them with calls to the localized strings. The strings are not necessarily localized yet.