kmod: actually ignore missing module deps#4185
Merged
daandemeyer merged 1 commit intosystemd:mainfrom Feb 21, 2026
Merged
Conversation
Contributor
|
I don't think we need to look at builtin, I've had the same patch sitting in the buildstream PR (47fa51e) so if you copy that we can merge it unless there's a good reason to go with this version. |
Contributor
Author
|
Ahh ok, yeah I was just copying the condition that lead to the "ignoring" message being printed. It seems weird to me to have that message printed from a different set of conditions from the actual behavior. |
Prior to f9e7527, IIUC modules in todo were ignored when they were popped and `moddep.get(m)` returned None for any modules that were missin. After f9e7527, missing modules aren't actually ignored, which leads to e.g.: ``` ‣ aes is a dependency of cifs but is not installed, ignoring ‣ nls is a dependency of cifs but is not installed, ignoring ‣ aead2 is a dependency of cifs but is not installed, ignoring modinfo: ERROR: Module name nls not found. ``` (nls.ko doesn't exist, and shouldn't exist in recent (6.19-ish) kernel trees)
craftyguy
force-pushed
the
ignore-missing-modules
branch
from
610d2cc to
adf6285
Compare
Contributor
Author
|
Updated to drop the builtin condition |
daandemeyer
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to f9e7527, IIUC modules in todo were ignored when they were popped and
moddep.get(m)returned None for any modules that were missin. After f9e7527, missing modules aren't actually ignored, which leads to e.g.:(nls.ko doesn't exist, and shouldn't exist in recent (6.19-ish) kernel trees)