Skip to content

Fix prevent default action when use wheel and mouse events. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbrvi2008 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix prevent default action when use wheel and mouse events. #69

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d82b78a
Fix prevent default action when use wheel and mouse events.
Apr 18, 2023
073cfd0
Fix runtime change props: allowZoom, allowPan, allowWheel.
Apr 18, 2023
3aebb98
Fix override style.
May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,8 @@ const PrismaZoom = forwardRef<Ref, Props>((props, forwardedRef) => {
* @param {MouseEvent} event Mouse event
*/
const handleMouseWheel = (event: WheelEvent) => {
event.preventDefault()
if (!allowZoom || !allowWheel) return
event.preventDefault()

// Use the scroll event delta to determine the zoom velocity
const velocity = (-event.deltaY * scrollVelocity) / 100
Expand All @@ -408,8 +408,8 @@ const PrismaZoom = forwardRef<Ref, Props>((props, forwardedRef) => {
* @param {MouseEvent} event Mouse event
*/
const handleMouseStart = (event: MouseEvent) => {
event.preventDefault()
if (!allowPan || ignoredMouseButtons.includes(event.button)) return
event.preventDefault()

if (lastRequestAnimationIdRef.current) cancelAnimationFrame(lastRequestAnimationIdRef.current)
lastCursorRef.current = [event.pageX, event.pageY]
Expand All @@ -420,9 +420,8 @@ const PrismaZoom = forwardRef<Ref, Props>((props, forwardedRef) => {
* @param {MouseEvent} event Mouse event
*/
const handleMouseMove = (event: MouseEvent) => {
event.preventDefault()

if (!allowPan || !lastCursorRef.current) return
event.preventDefault()

const [posX, posY] = [event.pageX, event.pageY]
const shiftX = posX - lastCursorRef.current[0]
Expand Down Expand Up @@ -596,19 +595,19 @@ const PrismaZoom = forwardRef<Ref, Props>((props, forwardedRef) => {
refCurrentValue?.removeEventListener('touchcancel', handleTouchStop)
}
}
}, [])
}, [allowWheel, allowZoom, allowPan])

const attr = {
...divProps,
ref,
onDoubleClick: handleDoubleClick,
style: {
...divProps.style,
cursor: cursor,
willChange: 'transform',
transition: `transform ease-out ${transitionRef.current}s`,
touchAction: allowParentPanning && zoomRef.current === 1 ? 'pan-x pan-y' : 'none',
transform: `translate3d(${posRef.current[0]}px, ${posRef.current[1]}px, 0) scale(${zoomRef.current})`,
...divProps.style,
},
}

Expand Down