IRGen/Runtime: Fix discrepancies in Borrow type layout.#87046
Merged
jckarter merged 1 commit intoswiftlang:mainfrom Feb 10, 2026
Merged
IRGen/Runtime: Fix discrepancies in Borrow type layout.#87046jckarter merged 1 commit intoswiftlang:mainfrom
jckarter merged 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci Please test |
Azoy
approved these changes
Feb 6, 2026
jckarter
force-pushed
the
borrow-layout-sync
branch
from
0955f1a to
7a18f93
Compare
Contributor
Author
|
@swift-ci Please test |
1 similar comment
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test Windows |
jckarter
force-pushed
the
borrow-layout-sync
branch
from
7a18f93 to
029bb51
Compare
Contributor
Author
|
@swift-ci Please test |
On the compiler side, `Borrow` ought to use extra inhabitants from its value representation, or at least the null pointer for the pointer representation. On the runtime side, the choice of representation needs to take size into account.
jckarter
force-pushed
the
borrow-layout-sync
branch
from
029bb51 to
8d41f21
Compare
Contributor
Author
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the compiler side,
Borrowought to use extra inhabitants from its value representation, or at least the null pointer for the pointer representation.On the runtime side, the choice of representation needs to take size into account.