[Concurrency] Add more info to tracing calls.#87021
Open
mikeash wants to merge 1 commit intoswiftlang:mainfrom
Open
[Concurrency] Add more info to tracing calls.#87021mikeash wants to merge 1 commit intoswiftlang:mainfrom
mikeash wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Contributor
mikeash
commented
Feb 6, 2026
mikeash
commented
- Have job_run include the actor, executor, and task name.
- Make task_status_changed only trace if one of the tracked values actually changed.
- Add a job_enqueue_executor that covers enqueueing jobs on non-main gobal executors.
- Actually end the actor lifetime signpost interval.
- Include the actor metadata and context descriptor pointers in actor enqueue/dequeue so the type can be identified.
ktoso
approved these changes
Feb 6, 2026
* Have job_run include the actor, executor, and task name. * Make task_status_changed only trace if one of the tracked values actually changed. * Add a job_enqueue_executor that covers enqueueing jobs on non-main gobal executors. * Actually end the actor lifetime signpost interval. * Include the actor metadata and context descriptor pointers in actor enqueue/dequeue so the type can be identified.
mikeash
force-pushed
the
improve-concurrency-signposts
branch
from
ea8e7dd to
5645233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.