Skip to content

Comments

[CMake] Introduce swift-syntax-dev component#86677

Open
rintaro wants to merge 1 commit intoswiftlang:mainfrom
rintaro:swift-syntax-dev
Open

[CMake] Introduce swift-syntax-dev component#86677
rintaro wants to merge 1 commit intoswiftlang:mainfrom
rintaro:swift-syntax-dev

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Jan 20, 2026

  • Separate .swiftmodule from swift-syntax-lib component
  • Include SwiftSyntaxMacrosGenericTestSupport libraries and modules in swift-syntax-dev component

rdar://122209853
rdar://114280017

* Separate `.swiftmodule` from `swift-syntax-lib` component
* Include `SwiftSyntaxMacrosGenericTestSupport` libraries and modules in
  `swift-syntax-dev` component

rdar://122209853
rdar://114280017
@rintaro
Copy link
Member Author

rintaro commented Jan 20, 2026

swiftlang/swift-syntax#3248
@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Jan 20, 2026

swiftlang/swift-syntax#3248
@swift-ci Please build toolchain

@rintaro rintaro changed the title [CMake] Introduce swift-sytnax-dev component [CMake] Introduce swift-syntax-dev component Jan 20, 2026
@compnerd
Copy link
Member

Note that this might require changes for the Windows build, including potentially the installer manifest.

@rintaro
Copy link
Member Author

rintaro commented Jan 21, 2026

@compnerd apparently Windows installer image doesn't include SwiftSyntax*.swiftmodule so no need to update swift-installer-scripts. Also, for building FoudationMacros etc., modules in the build directory are used. So I don't think we need to "install" .swiftmodule at all. Is there any particular area we need to look at?

@rintaro
Copy link
Member Author

rintaro commented Jan 21, 2026

@swift-ci Please smoke test Windows

@rintaro rintaro marked this pull request as ready for review January 21, 2026 19:06
@rintaro
Copy link
Member Author

rintaro commented Jan 21, 2026

swiftlang/swift-syntax#3248
@swift-ci Please smoke test Windows

@compnerd
Copy link
Member

compnerd commented Jan 22, 2026

@compnerd apparently Windows installer image doesn't include SwiftSyntax*.swiftmodule so no need to update swift-installer-scripts. Also, for building FoudationMacros etc., modules in the build directory are used. So I don't think we need to "install" .swiftmodule at all. Is there any particular area we need to look at?

I was concerned that the components might result in something missing on Windows for the installer. It's an easy check ... which is already done via the Windows toolchain build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants