[WIP] Parse some P? and any P? as (some P)? and (any P)?.#3268
Draft
allevato wants to merge 1 commit intoswiftlang:mainfrom
Draft
[WIP] Parse some P? and any P? as (some P)? and (any P)?.#3268allevato wants to merge 1 commit intoswiftlang:mainfrom
some P? and any P? as (some P)? and (any P)?.#3268allevato wants to merge 1 commit intoswiftlang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward the change pitched at https://forums.swift.org/t/pitch-allow-some-p-and-any-p-removing-the-need-for-parentheses/84656.
This isn't quite done. I'm having trouble with the diagnostic for
some P & Q?. I thinkParseDiagnosticsGeneratornever actually gets into my new visitor logic because the node itself doesn't have the error flag set in the parser. I need to figure out the best way to set that.The swiftlang/swift PR will be updated to move the changes into the C++ parser later; I still have some tests to fix.