[Swift Build] Don't set EXECUTABLE_PREFIX when building dylib targets as frameworks#9805
Merged
owenv merged 1 commit intoswiftlang:mainfrom Mar 12, 2026
Merged
Conversation
owenv
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Mar 12, 2026
owenv
force-pushed
the
owenv/framework-prefix
branch
from
162190a to
2f4a029
Compare
Contributor
|
@swift-ci test |
Contributor
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci smoke test Linux |
Contributor
Author
|
@swift-ci test linux |
pmattos
approved these changes
Mar 12, 2026
pmattos
reviewed
Mar 12, 2026
| fileprivate func withGeneratedPIF( | ||
| fromFixture fixtureName: String, | ||
| addLocalRpaths: Bool = true, | ||
| shouldCreateDylibForDynamicProducts: Bool = true, |
Contributor
There was a problem hiding this comment.
suggestion. Given the default is false in constructDefaultParametersForTesting shouldn't we stick to false here as well?
Contributor
Author
There was a problem hiding this comment.
hmm, yeah we might want to just generally drop a lot of the default values for this parameter, it makes it easier to make mistakes. I'll probably look at that as a follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we can end up with a framework that looks like: X.framework/libX