Refactor more properties to use the new BuildFlags type#9801
Merged
jakepetroules merged 1 commit intoswiftlang:mainfrom Mar 12, 2026
Merged
Refactor more properties to use the new BuildFlags type#9801jakepetroules merged 1 commit intoswiftlang:mainfrom
jakepetroules merged 1 commit intoswiftlang:mainfrom
Conversation
jakepetroules
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
jakepetroules
commented
Mar 11, 2026
| relativeTo: XCTestInstallation | ||
| ).pathString, | ||
| ] | ||
| ].map { BuildFlag(value: $0, source: .defaultWindowsSettings) } |
Contributor
Author
There was a problem hiding this comment.
As far as I can tell, all these testing search paths are handled correctly already.
jakepetroules
commented
Mar 11, 2026
jakepetroules
force-pushed
the
eng/PR-build-flags
branch
from
90e23b7 to
814ac8f
Compare
Contributor
Author
|
@swift-ci test |
owenv
reviewed
Mar 11, 2026
jakepetroules
force-pushed
the
eng/PR-build-flags
branch
from
814ac8f to
0120fbc
Compare
Contributor
Author
|
@swift-ci test |
This brings us further along on not passing redundant and incompatible flags to Swift Build (swiftlang#9756). There is only one remaining unannotated flag, in Sources/Build/LLBuildCommands.swift, which appears to be specific only to the legacy build system. The remaining ones are in a deprecated constructor not used within SwiftPM itself, and in tests.
jakepetroules
force-pushed
the
eng/PR-build-flags
branch
from
0120fbc to
f19edbf
Compare
Contributor
Author
|
@swift-ci test |
owenv
approved these changes
Mar 12, 2026
Contributor
Author
|
@swift-ci test windows platform |
github-project-automation
bot
moved this from In Progress
to Done
in SwiftPM on SwiftBuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings us further along on not passing redundant and incompatible flags to Swift Build (#9756).
There is only one remaining unannotated flag, in Sources/Build/LLBuildCommands.swift, which appears to be specific only to the legacy build system. The remaining ones are in a deprecated constructor not used within SwiftPM itself, and in tests.