Mark Swift Build as the default build system#9661
Mark Swift Build as the default build system#9661owenv wants to merge 3 commits intoswiftlang:mainfrom
Conversation
|
@swift-ci test |
6a98f17 to
174b47d
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@swift-ci test self hosted |
|
@swift-ci test |
|
@swift-ci test self hosted windows |
|
@swift-ci test linux |
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test linux |
|
@swift-ci test |
|
@swift-ci test windows |
|
swiftlang/swift#87683 @swift-ci test windows |
2 similar comments
1 similar comment
|
@swift-ci test windows |
| value.append("linux") | ||
| elif "windows" in targetTriple: | ||
| value.append("windows") | ||
| return "-".join(value).capitalize() |
There was a problem hiding this comment.
can we add a macos case and then make the else case an error? otherwise this will just be wrong on FreeBSD, for example (and we may actually hit that during FreeBSD bringup?)
Utilities/bootstrap
Outdated
| # get_build_target(args,cross_compile=True) | ||
| 'out', | ||
| 'Products', | ||
| 'Debug-android', # ? |
There was a problem hiding this comment.
yes, this the the correct directory suffix name
| ) | ||
|
|
||
| let rootPackagesPaths = rootPackages.map { $0.path } | ||
| let ids = rootPackagesPaths.map { $0.pathString}.joined(separator: ",") |
There was a problem hiding this comment.
Do any of these need to be sorted for determinism?
| case .native: "Native Build System" | ||
| case .swiftbuild: "Swift Build build engine (preview; recommended for feedback and testing. Report issues at https://github.com/swiftlang/swift-package-manager/issues)" | ||
| case .swiftbuild: "Swift Build build engine (Report issues at https://github.com/swiftlang/swift-package-manager/issues)" | ||
| case .xcode: "Xcode build system integration (discouraged)" |
There was a problem hiding this comment.
time to mark "deprecated" at this point?
| @@ -228,7 +228,7 @@ public struct BuildSystemProvider { | |||
| public var defaultValueDescription: String { | |||
| switch self { | |||
| case .native: "Native Build System" | |||
There was a problem hiding this comment.
time to mark "deprecated" at this point?
1118ffd to
b0ca921
Compare
|
@swift-ci test |
|
@swift-ci test windows |
b0ca921 to
863ed1c
Compare
|
@swift-ci test |
863ed1c to
a959098
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test macOS |
Co-authored-by: Bassam Khouri <[email protected]>
a959098 to
6b32581
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
|
@swift-ci test self hosted Windows |
|
@swift-ci test macOS |
|
@swift-ci test macOS self hosted |
|
@swift-ci test macOS |
swift-bootstrapexecutable