Handle request stream ending before receiving request end#54
Merged
aryan-25 merged 2 commits intoswift-server:mainfrom Feb 6, 2026
Merged
Handle request stream ending before receiving request end#54aryan-25 merged 2 commits intoswift-server:mainfrom
aryan-25 merged 2 commits intoswift-server:mainfrom
Conversation
Motivation: In swift-server#44, we introduced a `fatalError` in the case where the request stream ends before the request end part is received. The server should not fatalError in this scenario. Modifications: Replaced the `fatalError` in the scenario with a `throw`. Result: The server no longer fatal errors when the request stream ends before the request end part is received.
gjcairo
approved these changes
Feb 6, 2026
Collaborator
|
NB for the future: we should be adding regression tests when we fix things like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In #44, we introduced a
fatalErrorinHTTPRequestConcludingAsyncReaderwhen the request stream ends before the request end part is received. This is incorrect behaviour, and the server should not fatal error in this scenario.Modifications:
Replaced the
fatalErrorwith athrow.Result:
The server no longer fatal errors when the request stream ends before the request end part is received.