fix(style): fix authorize popup button overlap in Firefox#10804
Open
maruthang wants to merge 1 commit intoswagger-api:masterfrom
Open
fix(style): fix authorize popup button overlap in Firefox#10804maruthang wants to merge 1 commit intoswagger-api:masterfrom
maruthang wants to merge 1 commit intoswagger-api:masterfrom
Conversation
Add display: flex to .authorize inside .auth-btn-wrapper to override the display: inline from the global .btn.authorize rule. Firefox does not automatically blockify inline elements inside flex containers, causing buttons to overlap. Fixes swagger-api#6649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
display: flexto.authorizeinside.auth-btn-wrapperto override thedisplay: inlinefrom the global.btn.authorizerule in_buttons.scss. Firefox does not automatically blockify inline elements inside flex containers (unlike Chrome), causing the Authorize and Close buttons in the authorization popup to overlap.Motivation and Context
Fixes #6649
The Authorize popup dialog buttons overlap in Firefox because
.btn.authorizesetsdisplay: inline, which Firefox doesn't auto-blockify inside the flex container.auth-btn-wrapper.How Has This Been Tested?
test/e2e-cypress/e2e/bugs/6649.cy.js) that opens the authorize popup and verifies the Authorize and Close buttons do not horizontally overlapScreenshots (if appropriate):
N/A — CSS-only fix, visual overlap issue in Firefox
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests