fix(parser-adapter-yaml-1-2): use WebTreeSitter for Node.js lexical analysis#5139
Open
fix(parser-adapter-yaml-1-2): use WebTreeSitter for Node.js lexical analysis#5139
Conversation
| // acquire lock | ||
| parserInitLock = Parser.init() | ||
| .then(() => Parser.Language.load(treeSitterYaml)) | ||
| .then((jsonLanguage) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| .then((jsonLanguage) => { | |
| .then((yamlLanguage) => { |
Comment on lines
+28
to
+32
| } else if (parser === null) { | ||
| throw new ApiDOMError( | ||
| 'Error while initializing web-tree-sitter and loading tree-sitter-yaml grammar.', | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
can this statement be reached?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where using ApiDOM in non-browser environments would still cause the error fixed in #5045 by switching to using
web-tree-sitterinstead oftree-sitterin Node.js adapter.Note that this could have a negative impact on performance in Node.js environments, at least from taking a look at the documentation for web-tree-sitter:
TODO: