Skip to content

test: handle charm icons #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KTibow merged 1 commit into from
Mar 8, 2026
+4 −1
Merged

test: handle charm icons #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/regression/compare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ const runTests = async (list) => {
);

// ignore small aliasing issues
const isMatch = matched <= 4;
const threshold = originalPng.width <= 16 ? 3 : 4;
const isMatch = matched <= threshold;
const namePosix = pathToPosix(name);
const expectedToMismatch = expectMismatch.includes(namePosix);

Expand Down
2 changes: 2 additions & 0 deletions test/regression/lists/expect-mismatch.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ W3C_SVG_11_TestSuite/svg/styling-css-01-b.svg
W3C_SVG_11_TestSuite/svg/styling-css-04-f.svg

# broken and pending fix
charm-icons-0.18.0/docs/img/splash.svg
charm-icons-0.18.0/icons/atom.svg
oxygen-icons-5.116.0/scalable/actions/hidef/tools-rip-audio-cd.svg
oxygen-icons-5.116.0/scalable/actions/im-ban-kick-user.svg
oxygen-icons-5.116.0/scalable/actions/im-ban-user.svg
Expand Down
Loading