fix: clean up injected styles to prevent background persisting after errors (#1363)#1917
Open
AbdullahShafqat-OG wants to merge 2 commits intosveltejs:mainfrom
Open
Conversation
|
@AbdullahShafqat-OG is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
AbdullahShafqat-OG
force-pushed
the
persistent-background-after-errors
branch
from
a03a3f1 to
ef3c643
Compare
AbdullahShafqat-OG
force-pushed
the
persistent-background-after-errors
branch
from
ef3c643 to
8c97a4e
Compare
AbdullahShafqat-OG
force-pushed
the
persistent-background-after-errors
branch
from
8c97a4e to
2505771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in the Advanced Svelte tutorial where the
deepsea.webpbackground image persists across lessons after a runtime error.The problem occurred when a runtime error (e.g. referencing an undefined variable) interrupted normal cleanup in the REPL.
:global()styles injected by the bundler were not properly removed, causing the background image to persist even after navigating to other lessons.This has been resolved by assigning
svelte-prefixed IDs to bundler-injected<style>elements. This allows them to be reliably identified and cleaned up between REPL evaluations, ensuring that stale global styles do not leak across lessons.Fixes #1363
Before
After