[chore] replace deprecated String.prototype.substr()#1428
Draft
CommanderRoot wants to merge 1 commit intosveltejs:masterfrom
Draft
[chore] replace deprecated String.prototype.substr()#1428CommanderRoot wants to merge 1 commit intosveltejs:masterfrom
CommanderRoot wants to merge 1 commit intosveltejs:masterfrom
Conversation
Member
|
Converting this to a draft because I'm not sure if I would want to do this just because substr is deprecated (I don't think it will ever be removed honestly). |
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
CommanderRoot
force-pushed
the
rm-deprecated-substr
branch
from
10e2c30 to
83c52af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.