feat(migrate): defer formatting to project format script#1149
Open
jycouet wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 08b7916 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jycouet
force-pushed
the
feat/app-state-migration
branch
from
f31ac69 to
55fc80c
Compare
Migrate now runs the nearest `format`/`fmt` package.json script (walking up to the workspace root) before falling back to prettier on modified files. `formatFiles` takes a `strategy` param; create/add keep the files-only path.
jycouet
force-pushed
the
feat/migrate-format-strategy
branch
from
29ade20 to
08b7916
Compare
jycouet
changed the base branch from
feat/app-state-migration
to
feat/sv-migrate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sv migratenow formats using the project's own setup instead of always shelling out toprettieron the modified files:format/fmtpackage.jsonscript, walking up fromcwdto the workspace root (monorepo-aware via existingfindWorkspaceRoot, which usespnpm-workspace.yaml/workspaces- submodule-safe, not.git). The script owns its scope and tooling, so biome/dprint/etc. are respected.prettier --write --ignore-unknown <files>when no such script exists.formatFilesgains astrategyparam;create/addkeep the existing files-only behavior.