feat: migration-task comment management#1147
Merged
Merged
Conversation
- @migration-task comments now work in .svelte files (insert real Comment
nodes into the fragment, since the Svelte printer ignores the JS Comments
registry); fixes the env task silently dropping them.
- single addMigrationTask(message, target): { comments, node } for JS/TS,
{ fragment, anchor? } for .svelte.
- split migrate/index.ts into index.ts (framework) + migration-task.ts.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets
feat/sv-migrate.@migration-taskcomments now also work in.sveltefiles. The Svelte printer ignores the JSCommentsregistry, so we insert realCommentnodes into the fragment. Fixes the environment task silently dropping these comments.addMigrationTask(message, target)API, where the target picks the placement:{ comments, node }for JS/TS,{ fragment, anchor? }for.svelte.migrate/index.tsintoindex.ts(thedefineMigration*framework) +migration-task.ts(the comment API, paired with its spec).