Updates to make_watertight variables#672
Merged
gonuke merged 2 commits intosvalinn:developfrom Apr 11, 2020
Merged
Conversation
pshriwise
changed the title
Member
|
LGTM - I'll merge on passing tests |
Member
|
Thanks @pshriwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #666 addressing a comment from #660 related to our
make_watertightfiles. Primarily, it updates any non-global/non-static variables with capitalized names to a lower case version.There are also couple of small changes related to cleanup or clarity in comments.