-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Add dark mode support #1815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thiagokroger
wants to merge
11
commits into
superplanehq:main
Choose a base branch
from
thiagokroger:feat/dark-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9f7658 to
ac973f8
Compare
e5847f7 to
6d082e3
Compare
110ddad to
0fad515
Compare
d409598 to
272773c
Compare
Implements comprehensive dark mode theming across the application: - Add theme toggle with system preference detection - Update UI components to support dark/light themes - Ensure proper contrast and accessibility in dark mode - Default to light theme with user preference persistence Closes superplanehq#1128 Signed-off-by: thiagokroger <[email protected]>
- Add dark mode styling to canvas log sidebar - Update execution chain UI components for dark theme - Apply dark mode to organization settings page - Add environment variable to control appearance settings visibility - Fix cursor styling issues in dark mode Signed-off-by: thiagokroger <[email protected]>
…Storage errors - Add dark mode variants to waiting state in TIME_GATE_STATE_MAP - Wrap localStorage access in try-catch to prevent crashes in Safari private browsing mode or when storage is blocked Signed-off-by: thiagokroger <[email protected]>
…utation - Add appName to list_incidents mapper for proper dark mode icon inversion - Prevent install modal from closing via overlay/Escape while mutation is pending Signed-off-by: thiagokroger <[email protected]>
aa86e04 to
e732d92
Compare
Signed-off-by: thiagokroger <[email protected]>
Signed-off-by: thiagokroger <[email protected]>
The refactoring to centralized APP_LOGO_MAP removed support for AWS Lambda icons. This restores the custom icon for AWS building blocks. Signed-off-by: thiagokroger <[email protected]>
Resolve conflicts in: - IntegrationDetails.tsx: Keep dark mode styling (neutral-*), adopt Integration terminology - Integrations.tsx: Keep dark mode styling, use new Integration modal structure - SettingsTab.tsx: Keep dark mode icon styling, adopt Integration terminology Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: thiagokroger <[email protected]>
551334a to
fddbd63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
- Remove unused Dialog imports from Integrations.tsx - Change block.appName to block.integrationName in BuildingBlocksSidebar - Change appName to integrationName in componentSidebar Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: thiagokroger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements dark mode theming across the application:
Important to know:
Features added
Closes #1128
Note
Adds first-class dark mode across the app with theme persistence and system detection.
ThemeProvider/useThemeandThemeSelector(gated byVITE_ENABLE_THEMESviaisThemeConfigEnabled) replaceuseDarkMode;Appwraps content andToaster/dialogs adapt toeffectiveTheme.darkvariables, scrollbar/JSON viewer dark styles, and Tailwind@custom-variant dark (&:is(.dark *))APP_LOGO_MAPandDARK_ICONS_NEEDING_INVERT; components/mappers now passappNameinstead oficonSrcwhere applicableisThemeConfigEnabledenv util; numerous pages conditionally render Appearance section withThemeSelectorhtml-to-image1.11.11 → 1.11.13Written by Cursor Bugbot for commit 273ad6f. This will update automatically on new commits. Configure here.