basic implementation of comma-separated json#110
Draft
lillianberryfly wants to merge 2 commits intomainfrom
Draft
basic implementation of comma-separated json#110lillianberryfly wants to merge 2 commits intomainfrom
lillianberryfly wants to merge 2 commits intomainfrom
Conversation
jeromegn
reviewed
Dec 4, 2023
| let (data_tx, mut data_rx) = channel(512); | ||
|
|
||
| tokio::spawn(async move { | ||
| if !pms.ndjson { |
Member
There was a problem hiding this comment.
I think we could do Accept: application/ndjson as a header. At least it's generally how content type is negotiated :)
I just invented that, but maybe there's a better mime type for that.
|
|
||
| tokio::spawn(async move { | ||
| if !pms.ndjson { | ||
| if let Err(e) = tx.send_data(bytes::Bytes::from_static(b"[")).await { |
Member
There was a problem hiding this comment.
It would be cleaner to implement a tokio_util::codec::{Encoder,Decoder} for this format!
I wouldn't hold back this PR for that though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#106