Skip to content

fix(cli): persist legacy telemetry opt-out#5465

Merged
jgoux merged 2 commits into
developfrom
codex/fix-telemetry-notice-from-develop
Jun 4, 2026
Merged

fix(cli): persist legacy telemetry opt-out#5465
jgoux merged 2 commits into
developfrom
codex/fix-telemetry-notice-from-develop

Conversation

@jgoux
Copy link
Copy Markdown
Contributor

@jgoux jgoux commented Jun 4, 2026

What changed

This makes the telemetry state file compatible in both directions between the Go legacy CLI and the TypeScript telemetry runtime.

The Go telemetry disable command writes the legacy state shape with enabled: false, while the TypeScript runtime expects the newer consent: denied shape before suppressing the first-run telemetry notice. Because the runtime treated the legacy file as invalid or missing, every TTY command could show the telemetry notice again after opt-out.

The TypeScript reader now maps legacy enabled state into effective consent, and the Go loader now understands TypeScript consent state so either side preserves the user opt-out and identity/session fields.

Reviewer context

Regression coverage was added for legacy disabled/enabled state in the TypeScript consent/runtime tests, and for Go loading a TypeScript disabled telemetry config.

@jgoux jgoux requested a review from a team as a code owner June 4, 2026 07:02
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 4, 2026

Coverage Report for CI Build 26939098677

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.03%) to 63.968%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 29 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

29 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
internal/telemetry/state.go 21 82.4%
internal/utils/git.go 5 53.33%
internal/debug/postgres.go 3 66.09%

Coverage Stats

Coverage Status
Relevant Lines: 15850
Covered Lines: 10139
Line Coverage: 63.97%
Coverage Strength: 7.1 hits per line

💛 - Coveralls

@jgoux jgoux force-pushed the codex/fix-telemetry-notice-from-develop branch from e421273 to 36ff7f0 Compare June 4, 2026 07:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Supabase CLI preview

npx --yes https://pkg.pr.new/supabase@5465

Preview package for commit 6e6ecd1.

@jgoux jgoux enabled auto-merge (squash) June 4, 2026 07:56
@jgoux jgoux merged commit 0172ee9 into develop Jun 4, 2026
19 checks passed
@jgoux jgoux deleted the codex/fix-telemetry-notice-from-develop branch June 4, 2026 08:08
jgoux added a commit that referenced this pull request Jun 4, 2026
- **chore: sync API types from infrastructure (#5417)**
- **fix(cli): read Go Windows credentials in legacy TS (#5418)**
- **fix(ci): pass release channel to PR smoke workflow (#5419)**
- **fix(cli): enable vector buckets by default (#5421)**
- **fix(cli): bind a free port for edge-runtime diff containers
(#5424)**
- **ci(cli): publish pkg.pr.new previews after preview builds (#5420)**
- **feat(ci): notify Slack on release failures regardless of channel
(#5425)**
- **feat(cli): port telemetry  (#5422)**
- **docs(cli): modernize README and add installer (#5428)**
- **fix(docker): check Supabase image updates hourly (#5429)**
- **ci(cli): publish pkg.pr.new previews on pull requests (#5427)**
- **fix(docker): restore daily Dependabot schedule (#5430)**
- **fix(docker): bump the docker-minor group in
/apps/cli-go/pkg/config/templates with 5 updates (#5431)**
- **fix(cli): read Go Windows credentials via findCredentials (#5423)**
- **chore: sync API types from infrastructure (#5434)**
- **chore(ci): update Dependabot Go module paths (#5435)**
- **ci(release): use app token for release tag pushes (#5432)**
- **fix(deps): bump the go-minor group across 2 directories with 7
updates (#5437)**
- **fix(docker): bump the docker-minor group in
/apps/cli-go/pkg/config/templates with 2 updates (#5436)**
- **feat(cli): port link and unlink commands to native TypeScript
(#5426)**
- **feat(cli): port init (#5433)**
- **ci(release): use app token checkout for release pushes (#5439)**
- **fix(deps): bump the actions-major group across 1 directory with 14
updates (#5342)**
- **fix(docker): bump supabase/studio from 2026.06.01-sha-a4334a2 to
2026.06.03-sha-0bca601 in /apps/cli-go/pkg/config/templates in the
docker-minor group (#5441)**
- **chore(ci): add CLI preview PR comment (#5440)**
- **chore(ci): bump the actions-major group with 2 updates (#5443)**
- **chore(ci): use non-releasing actions dependabot prefix (#5442)**
- **fix(cli): inject S3 and sb key env variables into Studio (#5438)**
- **ci(preview): allow preview package PR comment (#5444)**
- **chore(release): add LLM release-notes prompt and approval-based
publish pipeline (#5330)**
- **chore(ci): fix propose release workflow dispatch (#5447)**
- **chore(ci): update workflows to skip CI for release-notes PRs
(#5455)**
- **feat(cli): port login and logout commands to native TypeScript
(#5446)**
- **chore(ci): bump aws-actions/configure-aws-credentials from 6.1.2 to
6.1.3 in the actions-major group (#5463)**
- **fix(docker): bump supabase/realtime from v2.103.1 to v2.103.2 in
/apps/cli-go/pkg/config/templates in the docker-minor group (#5464)**
- **fix(cli): persist legacy telemetry opt-out (#5465)**
- **fix(cli): restore Go debug output parity (#5467)**

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: supabase-cli-releaser[bot] <246109035+supabase-cli-releaser[bot]@users.noreply.github.com>
Co-authored-by: Julien Goux <hi@jgoux.dev>
Co-authored-by: Colum Ferry <cferry09@gmail.com>
Co-authored-by: Vaibhav <117663341+7ttp@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: VERSA SYNC STUDIOS <206948228+Versa-Sync-Studios@users.noreply.github.com>
Co-authored-by: Andrew Valleteau <avallete@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants