feat: improved grammar for pg-regress select.sql#672
Merged
juleswritescode merged 35 commits intomainfrom Feb 20, 2026
Merged
Conversation
…t IS in select clauses
…e-server into feat/insert-grammar
psteinroe
approved these changes
Feb 13, 2026
Co-Authored-By: Claude Opus 4.6 <[email protected]>
…e-server into feat/insert-grammar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal was to go through the
select.sqlfile in the postgres regression suite and make sure that if somebody would type it out token-by-token, the grammar parses correctly in treesitter.The tests in
partial_no_errors.rssimulate the "typing states" and check that we don't have any errors in the treesitter tree.The rest was just grammar adjustments and cleanup, and some downstream logic adjustments.
I think you can tell be looking at the snapshots that the approach is working very well. :)
I tried to build an agentic loop, but so far I've had little success. My hope is that once a couple of files are done, the agents have a better reference on how it should be done.