Skip to content

refactor: fix memory_helper.c naming to follow HACKING.md conventions#1327

Merged
suketa merged 1 commit intomainfrom
refactor/memory-helper-naming
Apr 18, 2026
Merged

refactor: fix memory_helper.c naming to follow HACKING.md conventions#1327
suketa merged 1 commit intomainfrom
refactor/memory-helper-naming

Conversation

@suketa
Copy link
Copy Markdown
Owner

@suketa suketa commented Apr 18, 2026

Summary

  • Rename all static functions in memory_helper.c from rbduckdb_memory_helper_* to memory_helper_s_* to follow HACKING.md rule 8: singleton methods must use the classname_s_methodname pattern
  • The rbduckdb_ prefix is reserved for extern functions (rule 11); using it on static functions was a naming convention violation

Test plan

  • Compiled successfully
  • All 1102 tests pass, 0 failures, 0 errors

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 18, 2026

Warning

Rate limit exceeded

@suketa has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 19 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 19 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3e267b84-04cd-4a72-b031-af9799f5dce5

📥 Commits

Reviewing files that changed from the base of the PR and between bcf2bf2 and 1500a45.

📒 Files selected for processing (1)
  • ext/duckdb/memory_helper.c
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/memory-helper-naming

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@suketa suketa merged commit d258548 into main Apr 18, 2026
45 checks passed
@suketa suketa deleted the refactor/memory-helper-naming branch April 18, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant