Skip to content

improve set_value error message.#1131

Merged
suketa merged 2 commits intomainfrom
improve_set_value_error_message
Mar 4, 2026
Merged

improve set_value error message.#1131
suketa merged 2 commits intomainfrom
improve_set_value_error_message

Conversation

@suketa
Copy link
Owner

@suketa suketa commented Mar 4, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved error message for unsupported data types to include the actual value being processed, making debugging clearer without changing behavior.

@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fcfa324d-900f-4d0e-bc87-e79dc855128f

📥 Commits

Reviewing files that changed from the base of the PR and between 83d3be9 and 8734794.

📒 Files selected for processing (1)
  • lib/duckdb/data_chunk.rb
🚧 Files skipped from review as they are similar to previous changes (1)
  • lib/duckdb/data_chunk.rb

📝 Walkthrough

Walkthrough

Changed the error message in DataChunk#set_value to include the inspected value alongside the type_id for unsupported types. No control flow, NULL handling, exported/public declarations, or other logic were modified.

Changes

Cohort / File(s) Summary
Error Message Change
lib/duckdb/data_chunk.rb
Adjusted the Unsupported type for DataChunk#set_value message to: includes #{value.inspect} with the type_id. No functional behavior altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐇 I nibbled on code, then gave a sigh,

The message now shows the value nearby.
Tiny change, but clear and spry,
Debugging hops along — oh my! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'improve set_value error message' directly and accurately describes the main change: enhancing the error message in the set_value method by including the actual value being processed.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch improve_set_value_error_message

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/duckdb/data_chunk.rb`:
- Line 104: The error message in DataChunk#set_value is missing a space before
the backtick; update the raise ArgumentError string in the set_value
implementation to insert a space between "value" and the backtick so it reads
"for value `#{value.inspect}`" (preserve the rest of the message and
interpolation including type_id).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1e2d67f1-397f-4990-ae82-e1a662389ed0

📥 Commits

Reviewing files that changed from the base of the PR and between 60b20f0 and 83d3be9.

📒 Files selected for processing (1)
  • lib/duckdb/data_chunk.rb

@suketa suketa merged commit f0a49e9 into main Mar 4, 2026
39 of 41 checks passed
@suketa suketa deleted the improve_set_value_error_message branch March 4, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant