DuckDB.cast accept DuckDB::LogicalType.

[suketa]

Summary by CodeRabbit

• Bug Fixes
  • Fixed type casting to properly handle logical type objects, resolving issues with integer value casting.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5119ad38-d379-4096-82d3-a5c5bbe89512

📥 Commits

Reviewing files that changed from the base of the PR and between 7e84bf5 and 60d7731.

📒 Files selected for processing (2)

• lib/duckdb/casting.rb
• test/duckdb_test/casting_test.rb

---

📝 Walkthrough

Walkthrough

The cast method in lib/duckdb/casting.rb is enhanced to unwrap DuckDB::LogicalType objects before processing, enabling proper handling when a LogicalType instance is passed as input. A corresponding test validates this new behavior for integer type casting.

Changes

Cohort / File(s)	Summary
Type Unwrapping lib/duckdb/casting.rb	Added logic to unwrap DuckDB::LogicalType objects in the cast method by extracting the underlying type before case dispatch.
LogicalType Casting Test test/duckdb_test/casting_test.rb	Added new test method to verify that casting a string representation of an integer to DuckDB::LogicalType::INTEGER produces the correct numeric result.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Casting #1126: Introduces the cast method that is directly modified by this PR's LogicalType unwrapping enhancement.
• add DuckDB::LogicalType.boolean DuckDB::LogicalType::BOOLEAN etc. #980: Adds DuckDB::LogicalType constructors and constants that this PR now properly integrates into the casting workflow.

Poem

🐰 A LogicalType wrapped up tight,
We unwrap it with delight!
Cast it true, without a care,
Type normalization in the air! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and directly describes the main change: enabling DuckDB.cast to accept DuckDB::LogicalType objects, which matches the implementation adding type unwrapping and the test verification.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch case_accepts_logical_type

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}