Skip to content

Add 2024 990 (2nd try) - #512

Merged
pikurasa merged 2 commits into
mainfrom
add-2024-990-2
Feb 10, 2026
Merged

Add 2024 990 (2nd try)#512
pikurasa merged 2 commits into
mainfrom
add-2024-990-2

Conversation

@pikurasa

Copy link
Copy Markdown
Contributor

This PR replaces #511

@sa-fw-an Please review. The http://localhost:5173/assets/tax-filings/2024-Form-990EZ.pdf page is not rendering; what am I missing?

@pikurasa
pikurasa requested a review from sa-fw-an October 28, 2025 23:56
@pikurasa pikurasa mentioned this pull request Oct 28, 2025
@github-actions

Copy link
Copy Markdown

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@sa-fw-an

Copy link
Copy Markdown
Member

@pikurasa The directory of the PDF where it is placed is wrong. It must be under public/assets/tax-filings . It works when placed under the mentioned directory.

@pikurasa

Copy link
Copy Markdown
Contributor Author

@pikurasa The directory of the PDF where it is placed is wrong. It must be under public/assets/tax-filings . It works when placed under the mentioned directory.

I guess I was confused because there are the same 990s under public/assets/990s/.

Given this, should I make a copy in both folders, or should I just move it to tax-filings?

@sa-fw-an

Copy link
Copy Markdown
Member

@pikurasa The directory of the PDF where it is placed is wrong. It must be under public/assets/tax-filings . It works when placed under the mentioned directory.

I guess I was confused because there are the same 990s under public/assets/990s/.

Given this, should I make a copy in both folders, or should I just move it to tax-filings?

You can move it to tax-filings. It would be better

@pikurasa
pikurasa merged commit c2e1a7a into main Feb 10, 2026
3 checks passed
@pikurasa

Copy link
Copy Markdown
Contributor Author

Perhaps the precise folder can be fixed in a future patch, but it needs to be on the website so I'm merging for now.

@sa-fw-an
sa-fw-an deleted the add-2024-990-2 branch May 7, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants