Allow setting custom query size limit NET-254#93
Open
kalabukdima wants to merge 1 commit intomasterfrom
Open
Conversation
Adds two config params: - query_size_limit — the default one stays at 256kb - ignore_deprecated_workers — avoids using deprecated worker versions
denisbsu
reviewed
Apr 6, 2026
| &config.assignments_url, | ||
| config.priorities.clone(), | ||
| ); | ||
| if config.ignore_deprecated_workers { |
Contributor
There was a problem hiding this comment.
Why not to pass it in constructor?
Contributor
Author
There was a problem hiding this comment.
The whole config doesn't split nicely without cloning, and passing this field alone increases the number of parameters in the constructor for almost no reason. Functions should accept no more than 2-3 arguments, so its limit is already reached.
denisbsu
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two config params:
query_size_limit— the default one stays at 256kbignore_deprecated_workers— avoids using deprecated worker versions