Update heif_enc.cc #1687
Merged
Update heif_enc.cc #1687
+62
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated VMT timestamp parser
farindk
reviewed
Jan 31, 2026
examples/heif_enc.cc
Outdated
Comment on lines
2209
to
2219
| if (fs.length() == 3) { // ms | ||
| ms = std::stoi(fs); | ||
| } | ||
| else if (fs.length() < 3) { // scale integer up | ||
| uint32_t scale = pow(10.0, 3 - fs.length()); | ||
| ms = std::stoi(fs) * scale; | ||
| } | ||
| else { // scale integer down | ||
| uint32_t scale = pow(10.0, fs.length() - 3); | ||
| ms = std::stoi(fs) / scale; | ||
| } |
Contributor
There was a problem hiding this comment.
You could either use std::pow(10, ... to keep all calculations integer, or use double scale = pow(10.0, ...). Then everything is subsumed in one case instead of three.
Author
There was a problem hiding this comment.
Thanks for your feedback @farindk
I've identified a mistake with my millisecond parser and the refactored code will not need to call pow at all or have multiple cases.
Refactored VMT timestamp parser
farindk
reviewed
Feb 5, 2026
| heif_raw_sequence_sample_set_duration(sample, ts - *prev_ts); | ||
| heif_track_add_raw_sequence_sample(track, sample); | ||
| } | ||
| else if (ts == *prev_ts) { |
Contributor
There was a problem hiding this comment.
Is it legal input to have similar timestamps following each other?
Author
There was a problem hiding this comment.
Yes - for several reasons, including:
- two VMT cues may share the same start time and have different end times
- two VMT cues that share the same start times and end times may have different cue ids or carry different payloads that are agnostic of each other
- where negative cue times are not supported, a simple workaround is to set those negative values to zero (destructively) which may produce unexpected duplicate times
Contributor
|
Thanks, I have merged it. |
Author
|
These changes add the following features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated VMT timestamp parser