Adding a new emscripten js method to parse depth images by Dakantz · Pull Request #1029 · strukturag/libheif

Dakantz · 2023-11-04T15:15:17Z

Adding a new emscripten js method to parse depth images

farindk · 2023-11-04T15:20:57Z

Thanks. One thing, though: your PR contains a lot of code reformatting in unrelated parts. Could you please clean up the PR such that only your new code is contained? Also make sure not to merge "master" into your branch. This will make the history unnecessarily complicated.

Dakantz · 2023-11-27T21:03:35Z

Sorry for the merge and formatting mistake, should be fixed now!

This is one of my first PRs 😅

I hope it can be merged now!

farindk · 2024-07-10T09:53:35Z

libheif/heif_emscripten.h

+    return depth_result;
+  }
+
+  depth_result.set("testdata", emscripten::val(emscripten::typed_memory_view(10, "123456890")));


looks like this is a leftover from testing

farindk · 2024-07-10T09:53:50Z

libheif/heif_emscripten.h

+        depth_result.set("data", emscripten::val(emscripten::typed_memory_view(stride * height, plane)));
+        depth_result.set("buffersize", stride * height);
+        depth_result.set("channel", channel);
+        depth_result.set("testdata", emscripten::val(emscripten::typed_memory_view(10, "123456890")));


another leftover

farindk · 2024-07-10T09:55:47Z

@EzraH442 Could you please do a review on this PR (only the changes in the file libheif/heif_emscripten.h.

EzraH442 · 2024-07-18T20:39:43Z

libheif/heif_emscripten.h

+  {
+    depth_result.set("err", "could not get handle of depth image");
+    depth_result.set("id", depth_image_id);
+    return depth_result;
+  }


It's better to return an heif_error here since heif_error is registered as an value object see here, that way it won't be necessary to manually delete the object on the JS side see here

EzraH442 · 2024-07-18T20:39:48Z

libheif/heif_emscripten.h

+    depth_result.set("err", "could not get image of depth image");
+    depth_result.set("msg", err.message);
+    depth_result.set("id", depth_image_id);
+    return depth_result;


same issue as above

EzraH442 · 2024-07-18T21:03:02Z

libheif/heif_emscripten.h

+  heif_item_id *ids = (heif_item_id *)malloc(n_images * sizeof(heif_item_id));
+


Also here there should be a check to make sure the malloc didn't return a null pointer, similar to here

EzraH442 · 2024-07-18T21:10:36Z

libheif/heif_emscripten.h

+  depth_result.set("id", depth_image_id);
+  return depth_result;
+}
+static emscripten::val heif_js_get_depth_imgs_decoded(struct heif_image_handle *handle)


based on what this function does a better name might be heif_js_image_handle_get_depth_img_handle, since it doesn't actually do any image decoding

EzraH442 · 2024-07-18T21:16:32Z

libheif/heif_emscripten.h

+    }
+  }
+
+  depth_result.set("err", "could get no plane of depth image");


This might be a little bit pedantic but I'd rephrase this error message to "could not get plane of depth image"

Ensures a fail-fast approach as used with other boxes

…trukturag#1612)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

NV12 data. "Full range" means that the pixel data ranges from 0 to 255. "Limited range" means that it's using a more constrained range, such as 16 to 235. Because the range is being clamped, it prevents images decoded with the VideoDecoder API from using the full range of color. Notably, this caused fully transparent backgrounds to be light gray due to the bottom end of the range starting at 16 instead of 0. Also, explicilty handle the mono image channel used to encode transparency information in HEIC images. Lastly, add the copyright header to decoder_webcodecs.h.

the decoded tiles. Remove custom limited range color remapping that was being done in the plugin.

https://developer.mozilla.org/en-US/docs/Web/API/VideoColorSpace/matrix.

range. The browser VideoDecoder API may return limited range color data even when the input source is using full range. The webcodecs plugin corrects for this by inspecting whether the output is encoded in full range or not. Note that if the original source is using limited range that this scaling could cause libheif to scale the data again when converting to RGB. This isn't easy to avoid at this time b/c plugins don't know whether the input source is using limited range or not. While it is technically present in the VUI SPS data, it is rather complicated to parse this structure as a one-off.

Signed-off-by: Dinika Saxena <dinika@greyllama.cc>

…porting this)

This reverts commit 96587ac, reversing changes made to 862415e.

…tz/libheif into feature/emscripten-fixes-and-depth

farindk · 2025-11-16T19:40:15Z

I think you should revert your push of 1870 commits :-)

Dakantz changed the title ~~Master~~ Adding a new emscripten js method to parse depth images Nov 4, 2023

farindk reviewed Jul 10, 2024

View reviewed changes

EzraH442 reviewed Jul 18, 2024

View reviewed changes

farindk and others added 20 commits May 8, 2025 12:49

fix clang-tidy false positive

0ef88ce

move functions to write metadata to heif_metadata.h

07988de

move functions to add thumbnails to heif_aux_images.h

81ffa12

compilation fixes

279f5c0

compilation fixes

50c8d40

extract new headers heif_encoding.h and heif_security.h from heif.h

9295118

extract new header heif_decoding/context/image_handle.h from heif.h

003ac41

add includes

1539712

extract new header heif_tiling.h from heif.h

7c0f877

adapt headers for enum checking scripts

ff8cef6

add include

4bf7fc8

move tile encoding function to heif_tiling.h

9ab6f71

fix compilation errors

da08c7b

move emscripten include to implementation file

ba96bf0

cleanup and sort headers

c42c7fe

fix includes

ef2371f

adapt enum-checking scripts

1187e3d

check alpha image error before trying to decode it

9c28f00

seq_boxes: check for sbgp read errors within loop

3e48c1b

Ensures a fail-fast approach as used with other boxes

fix fuzzing test where images are allocated without heif_context

6b79464

farindk and others added 28 commits October 27, 2025 16:43

fix typo

780e31b

PNG writer: check ICC validity and either fix it or skip writing ICC (s…

d1d608f

…trukturag#1612)

Webcodecs: Set NCLX color profile information on

67e4c1b

the decoded tiles. Remove custom limited range color remapping that was being done in the plugin.

Fix a typo in "bt2020ncl" to match the value in

b33788d

https://developer.mozilla.org/en-US/docs/Web/API/VideoColorSpace/matrix.

Fix some issues with the webcodecs build.

cb18c85

Check "max_output_buffer_entries" when returning warnings.

8c6f8e7

Sanitize auxiliary type when used as filename suffix

98a4bc7

Forward warnings to output image.

520067e

Fix duplicate warnings after color conversion.

f0e803e

always mark web-codecs as 'found' when enabled

220ac39

update README with webcodecs comment

19c55af

Merge branch 'webcodecs'

9386d0d

fix compilation with older emscripten version

f492327

remove 'experimental' for H.266 codec plugins

a529fd7

check for error in compressed unci image data

f4d9157

Improve documentation on how to use SVT as a builtin encoder

6f8dae4

Signed-off-by: Dinika Saxena <dinika@greyllama.cc>

CI: disable compiling with OpenJPH until macOS package is fixed

2f1994c

CI: macos-13 runners are deprecated. Use macos-15-intel instead.

fa1574d

[BSD3] return error when track parsing fails

4b215b7

fix wrong copy width in overlay images (thanks to Aldo Ristori for re…

b8c12a7

…porting this)

Add depth image parsing for emscripten

0db5306

Revert "Merge branch 'master' of https://github.com/strukturag/libheif"

7d92c38

This reverts commit 96587ac, reversing changes made to 862415e.

Revert reformatting

b221a15

Merge branch 'feature/emscripten-fixes-and-depth' of github.com:Dakan…

8c41d30

…tz/libheif into feature/emscripten-fixes-and-depth

re-fix minor issues?

6862deb

re-add features

86d6f59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding a new emscripten js method to parse depth images#1029

Adding a new emscripten js method to parse depth images#1029
Dakantz wants to merge 1871 commits intostrukturag:masterfrom
Dakantz:feature/emscripten-fixes-and-depth

Dakantz commented Nov 4, 2023

Uh oh!

farindk commented Nov 4, 2023

Uh oh!

Dakantz commented Nov 27, 2023

Uh oh!

farindk Jul 10, 2024

Uh oh!

farindk Jul 10, 2024

Uh oh!

farindk commented Jul 10, 2024

Uh oh!

EzraH442 Jul 18, 2024

Uh oh!

EzraH442 Jul 18, 2024

Uh oh!

EzraH442 Jul 18, 2024

Uh oh!

EzraH442 Jul 18, 2024

Uh oh!

EzraH442 Jul 18, 2024

Uh oh!

farindk commented Nov 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

		heif_item_id ids = (heif_item_id )malloc(n_images * sizeof(heif_item_id));

Uh oh!

Conversation

Dakantz commented Nov 4, 2023

Uh oh!

farindk commented Nov 4, 2023

Uh oh!

Dakantz commented Nov 27, 2023

Uh oh!

farindk Jul 10, 2024

Choose a reason for hiding this comment

Uh oh!

farindk Jul 10, 2024

Choose a reason for hiding this comment

Uh oh!

farindk commented Jul 10, 2024

Uh oh!

EzraH442 Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

EzraH442 Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

EzraH442 Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

EzraH442 Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

EzraH442 Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

farindk commented Nov 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants