Simplify Link payment confirmation by tillh-stripe · Pull Request #11064 · stripe/stripe-android

tillh-stripe · 2025-07-03T16:26:50Z

Summary

Motivation

Testing

Added tests
Modified tests
Manually verified

Screenshots

Before	After
before screenshot	after screenshot

Changelog

github-actions · 2025-07-03T16:33:33Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├──────────┬──────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old      │ new      │ diff     │ old       │ new       │ diff     
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼──────────
      dex │  4.5 MiB │  4.5 MiB │ -1.5 KiB │   9.9 MiB │   9.9 MiB │   -4 KiB 
     arsc │  2.5 MiB │  2.5 MiB │      0 B │   2.5 MiB │   2.5 MiB │      0 B 
 manifest │  5.7 KiB │  5.7 KiB │      0 B │  29.7 KiB │  29.7 KiB │      0 B 
      res │  918 KiB │  918 KiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │  3.5 MiB │  3.5 MiB │      0 B │   8.5 MiB │   8.5 MiB │      0 B 
    asset │  1.6 MiB │  1.6 MiB │ -1.4 KiB │   1.6 MiB │   1.6 MiB │ -1.4 KiB 
    other │  198 KiB │  198 KiB │     +7 B │ 373.9 KiB │ 373.9 KiB │      0 B 
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼──────────
    total │ 13.2 MiB │ 13.2 MiB │ -2.8 KiB │  24.3 MiB │  24.3 MiB │ -5.4 KiB 

         │         raw          │              unique               
         ├───────┬───────┬──────┼───────┬───────┬───────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff              
─────────┼───────┼───────┼──────┼───────┼───────┼───────────────────
   files │     2 │     2 │    0 │       │       │                   
 strings │ 48337 │ 48328 │   -9 │ 46825 │ 46821 │  -4 (+70 -74)     
   types │ 17199 │ 17192 │   -7 │ 16498 │ 16494 │  -4 (+64 -68)     
 classes │ 13913 │ 13911 │   -2 │ 13913 │ 13911 │  -2 (+6 -8)       
 methods │ 68908 │ 68863 │  -45 │ 67894 │ 67868 │ -26 (+1649 -1675) 
  fields │ 45484 │ 45483 │   -1 │ 45168 │ 45158 │ -10 (+1560 -1570) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6325 │ 6325 │  0

APK

      compressed      │     uncompressed     │                                
───────────┬──────────┼───────────┬──────────┤                                
 size      │ diff     │ size      │ diff     │ path                           
───────────┼──────────┼───────────┼──────────┼────────────────────────────────
 164.6 KiB │ -1.9 KiB │   373 KiB │ -6.3 KiB │ ∆ classes2.dex                 
   7.2 KiB │ -1.4 KiB │   7.1 KiB │ -1.4 KiB │ ∆ assets/dexopt/baseline.prof  
   4.3 MiB │   +436 B │   9.5 MiB │ +2.3 KiB │ ∆ classes.dex                  
  51.4 KiB │    +13 B │ 121.7 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
  54.8 KiB │     -6 B │ 121.7 KiB │      0 B │ ∆ META-INF/CERT.SF             
   1.1 KiB │     +1 B │     986 B │     +1 B │ ∆ assets/dexopt/baseline.profm 
───────────┼──────────┼───────────┼──────────┼────────────────────────────────
   4.6 MiB │ -2.8 KiB │  10.1 MiB │ -5.4 KiB │ (total)

DEX

STRINGS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   46825 │ 46821 │ -4 (+70 -74) 
  
  + , originalParams=
  + A non-null Link account is needed to share payment details
  + ConsumerPaymentDetailsShare(paymentMethod=
  + ForPaymentMethodMode(paymentDetails=
  + LD6/S;
  + LD7/r;
  + LU8/K;
  + LinkPaymentMethod(details=
  + Ll7/d;
  + Lm9/h;
  + Ly7/C;
  + [LC6/e0;
  + [LD7/e;
  + [LD7/j;
  + [LD7/q;
  + [LH8/b;
  + [LL9/d;
  + [LR8/b;
  + [LU8/B;
  + [LZ6/q;
  + [Le7/A2;
  + [Le7/A;
  + [Le7/D0;
  + [Le7/F2;
  + [Le7/G;
  + [Le7/H3;
  + [Le7/I0;
  + [Le7/I2;
  + [Le7/J1;
  + [Le7/L0;
  + [Le7/M;
  + [Le7/P1;
  + [Le7/P;
  + [Le7/Q0;
  + [Le7/T1;
  + [Le7/X0;
  + [Le7/Y;
  + [Le7/d0;
  + [Le7/e3;
  + [Le7/h1;
  + [Le7/i0;
  + [Le7/j1;
  + [Le7/l0;
  + [Le7/l;
  + [Le7/m2;
  + [Le7/n1;
  + [Le7/o0;
  + [Le7/p3;
  + [Le7/r0;
  + [Le7/s1;
  + [Le7/u0;
  + [Le7/u2;
  + [Le7/u3;
  + [Le7/w1;
  + [Le7/w;
  + [Le7/x2;
  + [Le7/z3;
  + [Lg7/b;
  + [Ll5/c;
  + [Ll5/f;
  + [Ll7/d;
  + [Lm6/L0;
  + [Lm7/f;
  + [Lm9/c;
  + [Lp8/I;
  + [Ls6/G;
  + [Lx7/u;
  + [Ly7/o;
  + [Ly7/y;
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"d841188","r8-mode":"full","version":"8.8.34"}
  
  - ConsumerPaymentDetails(details=
  - ConsumerPaymentDetailsShare(id=
  - LC6/s0;
  - LC6/t0;
  - LC6/u0;
  - LT2/a;
  - Le7/O3;
  - LinkPaymentDetails(linkPaymentDetails=
  - Ll5/i;
  - Lm7/h;
  - Lx7/y;
  - Passthrough(id=
  - [LC6/S;
  - [LC6/h0;
  - [LD7/a;
  - [LD7/f;
  - [LD7/k;
  - [LH8/c;
  - [LL9/e;
  - [LR8/c;
  - [LU8/A;
  - [LZ6/r;
  - [Le7/C0;
  - [Le7/C;
  - [Le7/D3;
  - [Le7/G2;
  - [Le7/H0;
  - [Le7/H2;
  - [Le7/I1;
  - [Le7/J0;
  - [Le7/K;
  - [Le7/N;
  - [Le7/O1;
  - [Le7/O3;
  - [Le7/P0;
  - [Le7/U;
  - [Le7/V1;
  - [Le7/W0;
  - [Le7/c0;
  - [Le7/d3;
  - [Le7/g1;
  - [Le7/h0;
  - [Le7/k1;
  - [Le7/l2;
  - [Le7/m0;
  - [Le7/m1;
  - [Le7/m;
  - [Le7/n0;
  - [Le7/q0;
  - [Le7/q3;
  - [Le7/r1;
  - [Le7/t0;
  - [Le7/t2;
  - [Le7/t3;
  - [Le7/v1;
  - [Le7/v;
  - [Le7/w2;
  - [Le7/y3;
  - [Le7/z2;
  - [Le7/z;
  - [Lg7/d;
  - [Ll5/d;
  - [Ll5/g;
  - [Ll7/c;
  - [Lm6/M0;
  - [Lm7/g;
  - [Lm9/a;
  - [Lp8/K;
  - [Ls6/I;
  - [Lx7/w;
  - [Ly7/n;
  - [Ly7/w;
  - linkPaymentDetails
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"de9bd9c","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   16498 │ 16494 │ -4 (+64 -68) 
  
  + LD6/S;
  + LD7/r;
  + LU8/K;
  + Ll7/d;
  + Lm9/h;
  + Ly7/C;
  + [LC6/e0;
  + [LD7/e;
  + [LD7/j;
  + [LD7/q;
  + [LH8/b;
  + [LL9/d;
  + [LR8/b;
  + [LU8/B;
  + [LZ6/q;
  + [Le7/A2;
  + [Le7/A;
  + [Le7/D0;
  + [Le7/F2;
  + [Le7/G;
  + [Le7/H3;
  + [Le7/I0;
  + [Le7/I2;
  + [Le7/J1;
  + [Le7/L0;
  + [Le7/M;
  + [Le7/P1;
  + [Le7/P;
  + [Le7/Q0;
  + [Le7/T1;
  + [Le7/X0;
  + [Le7/Y;
  + [Le7/d0;
  + [Le7/e3;
  + [Le7/h1;
  + [Le7/i0;
  + [Le7/j1;
  + [Le7/l0;
  + [Le7/l;
  + [Le7/m2;
  + [Le7/n1;
  + [Le7/o0;
  + [Le7/p3;
  + [Le7/r0;
  + [Le7/s1;
  + [Le7/u0;
  + [Le7/u2;
  + [Le7/u3;
  + [Le7/w1;
  + [Le7/w;
  + [Le7/x2;
  + [Le7/z3;
  + [Lg7/b;
  + [Ll5/c;
  + [Ll5/f;
  + [Ll7/d;
  + [Lm6/L0;
  + [Lm7/f;
  + [Lm9/c;
  + [Lp8/I;
  + [Ls6/G;
  + [Lx7/u;
  + [Ly7/o;
  + [Ly7/y;
  
  - LC6/s0;
  - LC6/t0;
  - LC6/u0;
  - LT2/a;
  - Le7/O3;
  - Ll5/i;
  - Lm7/h;
  - Lx7/y;
  - [LC6/S;
  - [LC6/h0;
  - [LD7/a;
  - [LD7/f;
  - [LD7/k;
  - [LH8/c;
  - [LL9/e;
  - [LR8/c;
  - [LU8/A;
  - [LZ6/r;
  - [Le7/C0;
  - [Le7/C;
  - [Le7/D3;
  - [Le7/G2;
  - [Le7/H0;
  - [Le7/H2;
  - [Le7/I1;
  - [Le7/J0;
  - [Le7/K;
  - [Le7/N;
  - [Le7/O1;
  - [Le7/O3;
  - [Le7/P0;
  - [Le7/U;
  - [Le7/V1;
  - [Le7/W0;
  - [Le7/c0;
  - [Le7/d3;
  - [Le7/g1;
  - [Le7/h0;
  - [Le7/k1;
  - [Le7/l2;
  - [Le7/m0;
  - [Le7/m1;
  - [Le7/m;
  - [Le7/n0;
  - [Le7/q0;
  - [Le7/q3;
  - [Le7/r1;
  - [Le7/t0;
  - [Le7/t2;
  - [Le7/t3;
  - [Le7/v1;
  - [Le7/v;
  - [Le7/w2;
  - [Le7/y3;
  - [Le7/z2;
  - [Le7/z;
  - [Lg7/d;
  - [Ll5/d;
  - [Ll5/g;
  - [Ll7/c;
  - [Lm6/M0;
  - [Lm7/g;
  - [Lm9/a;
  - [Lp8/K;
  - [Ls6/I;
  - [Lx7/w;
  - [Ly7/n;
  - [Ly7/w;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   67894 │ 67868 │ -26 (+1649 -1675) 
  
  + A6.G <init>(L, g2, a, Continuation)
  + A6.L g(E3, String, Long, String) → j
  + A6.Q <init>(P1)
  + A6.g <init>(g, c, e, r0, h)
  + A6.i0 <init>(L, I, l0, K)
  + A6.i0 d(K, f, Q, ContinuationImpl)
...✂

tillh-stripe · 2025-09-30T20:15:06Z

Closing in favor of #11652.

tillh-stripe force-pushed the tillh/remove-passthrough-consumerpaymentdetails branch 3 times, most recently from 9849517 to 5339445 Compare July 6, 2025 18:35

tillh-stripe added 9 commits July 8, 2025 16:23

Remove ConsumerPaymentDetails.Passthrough

324b156

Correct now?

6449b3f

Clean up LinkPaymentMethod

c1cb929

Clean up more

be3047c

Rename LinkPaymentDetails subclasses

ec898fe

Move method around

17c2f70

More simplification

6310939

Add comments

e03de31

[wip] tests

1c77164

tillh-stripe force-pushed the tillh/remove-passthrough-consumerpaymentdetails branch from 5339445 to 1c77164 Compare July 8, 2025 14:23

rebase issue

2d4bcde

tillh-stripe mentioned this pull request Aug 1, 2025

Populate billing address in passthrough #11249

Merged

3 tasks

tillh-stripe closed this Sep 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify Link payment confirmation#11064

Simplify Link payment confirmation#11064
tillh-stripe wants to merge 10 commits intomasterfrom
tillh/remove-passthrough-consumerpaymentdetails

tillh-stripe commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

tillh-stripe commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

tillh-stripe commented Jul 3, 2025

Summary

Motivation

Testing

Screenshots

Changelog

Uh oh!

github-actions bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tillh-stripe commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Jul 3, 2025 •

edited

Loading