Skip to content

Skip ITs on release branches - #233

Merged
see-quick merged 1 commit into
strimzi:mainfrom
see-quick:add-mutation-testing-and-do-not-run-integration-tests-in-release-branches
Jun 8, 2026
Merged

Skip ITs on release branches#233
see-quick merged 1 commit into
strimzi:mainfrom
see-quick:add-mutation-testing-and-do-not-run-integration-tests-in-release-branches

Conversation

@see-quick

@see-quick see-quick commented Jun 5, 2026

Copy link
Copy Markdown
Member

Type of change

  • Task

Description

This PR adds a condition where to run ITs. Currently we run it also on release branches but that would fail because such images are not present (GAs ones) as we are doing release candidates.

We can't run ITs in the release-* branches as we build images in separate repository.

Checklist

  • Update documentation
  • Update CHANGELOG.md (if present)
  • Reference relevant issue(s) and close them after merging
  • Write tests
  • Make sure all tests pass
  • Try your changes inside a Kubernetes cluster, not just from unit tests
  • AI assistance was used to create this PR

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added this to the 0.116.0 milestone Jun 5, 2026
@see-quick see-quick self-assigned this Jun 5, 2026
@see-quick
see-quick requested a review from a team June 5, 2026 12:20

@scholzj scholzj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doens't that suggest some issue in the build that should be fixed rather then skip the ITs?

@see-quick

Copy link
Copy Markdown
Member Author

Doens't that suggest some issue in the build that should be fixed rather then skip the ITs?

No, because when you run integration tests it would try to run tests with using 0.116.0 images (which are not present yet), as there are only 0.116.0-rc1. The build with ITs will be run in the release job with replaced images (i.e., using 0.116.0-rc1).

@scholzj

scholzj commented Jun 5, 2026

Copy link
Copy Markdown
Member

Doens't that suggest some issue in the build that should be fixed rather then skip the ITs?

No, because when you run integration tests it would try to run tests with using 0.116.0 images (which are not present yet), as there are only 0.116.0-rc1. The build with ITs will be run in the release job with replaced images (i.e., using 0.116.0-rc1).

Hmm, I guess that is an interesting issue with this 2 repositories approach 🤔

@scholzj
scholzj requested review from Frawless and scholzj June 5, 2026 12:30
@see-quick

Copy link
Copy Markdown
Member Author

Do you have anything more to this @scholzj?

@see-quick
see-quick merged commit 389fc19 into strimzi:main Jun 8, 2026
8 checks passed
see-quick added a commit that referenced this pull request Jun 8, 2026
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants